[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] include: correct re-building conditions around hypercall-defs.h
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- Date: Mon, 25 Jul 2022 13:24:35 +0100
- Authentication-results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "Andrew Cooper" <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Mon, 25 Jul 2022 12:25:01 +0000
- Ironport-data: A9a23:TQMUy6n1kd+IjO/SiFr4BGvo5gyQJkRdPkR7XQ2eYbSJt1+Wr1Gzt xJOX26FPf3fY2byKttwb4+0pkoCvMWEyYBgHgZp+Ck9EyMWpZLJC+rCIxarNUt+DCFioGGLT Sk6QoOdRCzhZiaE/n9BCpC48T8mk/ngqoPUUIbsIjp2SRJvVBAvgBdin/9RqoNziJ2yDhjlV ena+qUzA3f4nW8vWo4ow/jb8kk3466v4GpwUmEWPpingnePzxH5M7pHTU2BByOQapVZGOe8W 9HCwNmRlo8O105wYj8Nuu+TnnwiGtY+DyDX4pZlc/HKbix5jj4zys4G2M80Mi+7vdkrc+dZk 72hvbToIesg0zaldO41C3G0GAkmVUFKFSOuzdFSfqV/wmWfG0YAzcmCA2k9Iqkhq91+OVtW5 P5IAzkydC6Kl9+plefTpulE3qzPLeHuNYIb/Hph0SvYHbAtRpWrr6fivIECmm1q34YXQKiYN 5FxhTlHNXwsZzVGPEsXD5Qv2v+lnHDlfxVTqU6PpLpx6G/WpOB0+OewYIGIJ4PVLSlTtmaFm iXWoWf0OQE5FdWy72eH0XO0mMaayEsXX6pNTeblp5aGmma73XcPARcbUV+6p/iRiUOkXd9bb UsO9UIGsqwa5EGtCN7nUHWQomOAvxMac8pdFas98g7l4qje7hudB2MEZiVcc9Fgv8gzLRQ62 1nMk973CDhHtLyOVWnb5rqStSm1OyUeMSkFfyBscOcey4C9+sdp1EuJF4s9Vv7u5jHoJd3u6 zuViBFvvLwrt9Ya1fWQ9G/dvTu8m4ecG2bZ+T7rsnKZAhJRPdD4N9D1tQaAt56sP67CEADf4 SFsd9y2qblXUMrTzHHlrPAlRunB2hqTDNHLbbeD9bEF/i/lxXOsdJs4DNpWdBYwaZZsldMEj SbuVeJtCHx7ZiLCgVdfOd7ZNijT5fGI+S7Zfv7VdMFSRZN6aRWK+ipjDWbJgT29zhhzzvtvY cfCGSpJMZr9If08pAdaus9HieN7rszA7Ti7qW/HI+SPjuPFOS/9pUYtO1qSdOEphJ65TPHu2 48Gb6OilkQAONASlwGNrub/23hWciVgbX03wuQLHtO+zv1OQzt6Vq6Lme16I+SIXc19z4/1w 510YWcAoHKXuJENAVzihqxLAF83YatCkA==
- Ironport-hdrordr: A9a23:lsKUqKvvsfV+/9UvoYfRWAEo7skDdNV00zEX/kB9WHVpmszxra GTddAgpHjJYVcqKRUdcL+7VJVoLUmyyXcx2/h2AV7AZniChILLFvAA0WKK+VSJcEeSygce79 YDT0EXMqyIMbEQt6bHCWeDfeod/A==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Mon, Jul 25, 2022 at 02:08:04PM +0200, Jan Beulich wrote:
> For a .cmd file to be picked up, the respective target needs to be
> listed in $(targets). This wasn't the case for hypercall-defs.i, leading
> to permanent re-building even on an entirely unchanged tree (because of
> the command apparently having changed).
>
> Fixes: eca1f00d0227 ("xen: generate hypercall interface related code")
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>
> --- a/xen/include/Makefile
> +++ b/xen/include/Makefile
> @@ -114,7 +114,7 @@ all: $(obj)/xen/hypercall-defs.h
> $(obj)/xen/hypercall-defs.h: $(obj)/hypercall-defs.i
> $(srctree)/scripts/gen_hypercall.awk FORCE
> $(call if_changed,genhyp)
>
> -targets += xen/hypercall-defs.h
> +targets += hypercall-defs.i xen/hypercall-defs.h
Do you want to remove "hypercall-defs.i" from $(clean-files) at the same
time?
In any case,
Reviewed-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
Thanks,
--
Anthony PERARD
|
