[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v3 07/25] tools/hotplug: cleanup Makefiles
- To: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Fri, 22 Jul 2022 11:02:22 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=a4LYNAiJxauD9PPon6uI0OXhD+Qp4Tq+euSXLKEgZi0=; b=Y4BwKSaFcipvjPyWTzaYHy6H3WI36oerrBmiSq2BUzgBoJ9WpL6qbiXhRSxubkOcFiy7CLzO3CT7GeBfd/tdsCFEj/W1gB9+BrWDiiNLdFgWP7ydty57p18tQ+bpi+JsSRudcioZZ2eshhS7h6M7+t/zjKwwvR0DReqNqi+hh0qHKXvy+eDJXovfdLDHUV/2tfOSCHK/kcNdcP/ejvQiKn6UrWNcfDeaMMwtklUeiA9sJ0qp2hcRh5nsLcpgQDsrZy7it46oxeVaDJMoqO8XlDXkcvInFrFXHsEfVt2auFEtPuO4EcIqkSW2uKg16AChJjaF8KH/BPEhWHbEU8dSjA==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=a4LYNAiJxauD9PPon6uI0OXhD+Qp4Tq+euSXLKEgZi0=; b=WUei4b1o4TvkAue0eSTc06mDToX6LidkvLrfnEgXCu7zyC5zB5aN3hoSPy5BXOLiaoxhyQVB6LDyCqaEh+Dpm1M9m9relNqwIsoMbIDBp2fhRu9+sIiTc0X/4LUOD0E0Sppg1dx2hH/Q6ILnie7ONVZe1RBkEB6PtFefEPAVI72eSR4+EfaGw/LEjQSXjRBEfwoMOmHMyxro2sf9icehjnYx/kL2DnBDMGwFX8Osi1IwbQ6mS02ebUlsCv+uRVV4tomwfaerX1AJG5gK37nUQvk64moCLKutB1QvhnZQQb3X+bh0RQQtaGCR+8UkDhcnygrnYa8PJf9vbXOj+I93KQ==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=ND9BgXrNXqHDK95rnMISPLnNh79GtRJOTme44xhrb0ah1wrC/aAkCB9cbo96Y+mKdzBfBU0krDiKtuGBkl7OW9fNPLwoNewVQ0inZb9BPV7zx5Wm9KTJMXAUhYjF9MyjYenQ4QgbKiIhuuQv1ivLoLH1MSvgCtavDXbENCl3hoUla5vFTD6x8fwVvG0j3BeEljVkQ95V5taCYk/jeGLtYUb3yb5kuhTKVH9JoIbVPSAmlEh/+upA/BTNqQkNLy4iifAP7UOYoYwEK2L3Bggq97yVpYlXFMxnvDQEZ30wQobCbB0OYi1i1diUAcAyDw0zzVq9UrZHn+QZde+w2MpqJw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=efWUiu1GjxquQwmtIw3W7J6UUHeo8iITZxYaU0OmPNPDv6+jZBdhAgIKf37Us3uh4w7RU7zsH1uJlmTuq6xYR9Wz5z53ApJnoRPaEznoi+Is1NJXmUNLUbxBCWFjPktX7RRUVxhGVGOU/M23WtnRfn1nc67uj5TPBQyvyhbOBBoIE4g7U7Wo0g5pbmu1Xu47ZZoR+NQ9QjO9l7c+T2k7lUU8eKvQWa3isHN37F2m7NobZmFlFT9oIoD18nBeBpqe4zGuFbCF1C5ZrSNmuapQgwz+xKbtC7RhL+e1WG9vby8EuW7vjO/HOPdRDI4xK8CtfkscMz1ZU7Tig98TWZ9wEA==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Fri, 22 Jul 2022 11:02:43 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYh+Q6qu+KWis5mUCexJRiIhEBa62KZT+A
- Thread-topic: [XEN PATCH v3 07/25] tools/hotplug: cleanup Makefiles
> On 24 Jun 2022, at 17:04, Anthony PERARD <anthony.perard@xxxxxxxxxx> wrote:
>
> Remove "build" targets.
>
> Use simply expanded variables when recursively expanded variable
> aren't needed. (Use ":=" instead of "=".)
>
> Don't check if a directory already exist when installing, just create
> it.
>
> Fix $(HOTPLUGPATH), it shouldn't have any double-quote.
>
> Some reindentation.
>
> FreeBSD, "hotplugpath.sh" is already installed by common/.
>
> Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
Hi Antony,
> ---
> tools/hotplug/FreeBSD/Makefile | 11 +++--------
> tools/hotplug/Linux/Makefile | 16 ++++++----------
> tools/hotplug/Linux/systemd/Makefile | 16 +++++++---------
> tools/hotplug/NetBSD/Makefile | 9 +++------
> tools/hotplug/common/Makefile | 16 ++++++----------
> 5 files changed, 25 insertions(+), 43 deletions(-)
>
> diff --git a/tools/hotplug/FreeBSD/Makefile b/tools/hotplug/FreeBSD/Makefile
> index de9928cd86..a6552c9884 100644
> --- a/tools/hotplug/FreeBSD/Makefile
> +++ b/tools/hotplug/FreeBSD/Makefile
> @@ -2,18 +2,15 @@ XEN_ROOT = $(CURDIR)/../../..
> include $(XEN_ROOT)/tools/Rules.mk
>
> # Xen script dir and scripts to go there.
> -XEN_SCRIPTS = vif-bridge block
> +XEN_SCRIPTS := vif-bridge block
>
> -XEN_SCRIPT_DATA =
> +XEN_SCRIPT_DATA :=
Here (and also in NetBSD) the variable is empty, why are we keeping them
and the related code? Is it to keep a certain structure?
However the changes works and looks good to me, so your choice if it needs
to be addressed or not
Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>
|
