[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: Ping²: [PATCH] x86: enable interrupts around dump_execstate()
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Tue, 19 Jul 2022 12:54:58 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=msxlRL/HC5HQgsMWonauO60dvwfBFNbLtgNfN2ek0xQ=; b=UnEN5Be/fAcUhax14QiDBwC00qBVh2s5Y0PGSecrfoxlBItfAR8dH9HwzjSIWyH3Twch6zRdxmGot+3rzdxeJDzEV3qAvbdFRucl1KapS3gYEr7AgTCHwB2R5+wVW8FIJu1c/a6Rsdv9obX2stS1pEKtuIwBCbnot0Nb+NHOYyedmcsi5wkN2MMJxRpUEzsElCYLzqerNwBNPTBKp+zg9VCPhSfZDeef7y7wSrhawBqcN9/iVPmBNT11D+bbYIxDEyKsxrS6rEtM2C0S27RMpsTM6FisHXFoWhduEFEPQ867/FfZIpPYrY8SsYM+d0TUeOZvJOS7/bI9K3D4IJlmUQ==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=msxlRL/HC5HQgsMWonauO60dvwfBFNbLtgNfN2ek0xQ=; b=IOlKwd6onCXdgXrilTYzOqoMQNXG/Ei4eCA89tT440cWr/OpCOVrlUxZ8efObIlJHIYvx0W0JkUa09nAHQwpIymi9wxsO6nNf9Ux1KBzvPiQPoBtKJp07T8J+Sh9S8bKyt2MSccetpQhFaHJvP/yZrjnL/D0djjiyNv4UETndX3f4NqbDm4PR69WxBavB0TWDXuGH6xSlereE8+kbgAf1C0+ws1sPznNjF5NYePSE0mcwpnsrVWM6qHQo3un6Lku0AWc/XXPrvYftJtFf+qwkCGShLl3bccpPgoCRWgYj0M4gKKUTwlp0NmtrRS5iLXg9UIaNPSobl+SW8xTra5oSQ==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=kViW945caLFSJ6wDzCNTNXEbgfKsfWB/tpS0QK6VyiG/a0/5GMuGLpbo9RnXTMq1jUOMmpo5/4wLvdnAHucgQ9j52bG9g1oAz2+oN4ycRWg+lhMKDAESbFSZO3aiPiElVmGHm5UlyXlh5G6mZ4NDtRiW4f4k/joW0AeTJzCphth5snouH4xTOeYzEimJ+bJ/Nryxj5KKoGapfXgK2P5ssTSo3LtUsUGeC9m64gnqUukhWP0OezaCyErOaRjNVloo364FyyExV/6Sv3SBEKb2Wwn0mXgzFENFPqND9L5UUXu0bTx1cHjtELVZf3jl1di7twf7mNAJTwYKVmqKaQufgA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=D4k0JrJEZ1ZC0j8QOWgs0ce7961o+PEAEjTyMZ3aaZTJDwjF5ZPGoDWhufz9U+xCj5ABspzjsMxef0HQ50VqFeffsFRzu15ahSzQZr1PijElzzxaAPuadhfZRkVUId0v8ftUi7Bc0lr3D18awC2wjFwc6if2K+RrOxkokIcA5EJUJ9HipE78u2LHzLXRi2JBS+Jj+jAJRL01u2GgVmjVpBxKexGvk2qhnL0PMAszdfUcaS/a1DoVqdjDR2CFARhmdY4hGNbg5YKBDCHChvU2+qBOL6eeVpMtWG9qH8QGt80KDUyTtVF3AXFmcIC6jCCg/VjVReCMhD+EsMc8rKDPgg==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 19 Jul 2022 12:55:11 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYkIshAZJzP1BUJUaUK2Iq87bw6K2FnDcAgAAebSA=
- Thread-topic: Ping²: [PATCH] x86: enable interrupts around dump_execstate()
Hi Jan,
> -----Original Message-----
> From: Jan Beulich <jbeulich@xxxxxxxx>
> Henry,
>
> -------- Forwarded Message --------
> Subject: Ping²: [PATCH] x86: enable interrupts around dump_execstate()
>
> >On 11.01.2022 11:08, Jan Beulich wrote:
> >> On 16.12.2021 14:33, Jan Beulich wrote:
> >>> On 16.12.2021 12:54, Andrew Cooper wrote:
> >>>> On 13/12/2021 15:12, Jan Beulich wrote:
> >>>>> show_hvm_stack() requires interrupts to be enabled to avoids
> triggering
> >>>>> the consistency check in check_lock() for the p2m lock. To do so in
> >>>>> spurious_interrupt() requires adding reentrancy protection / handling
> >>>>> there.
> >>>>>
> >>>>> Fixes: adb715db698b ("x86/HVM: also dump stacks from
> show_execution_state()")
> >>>>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> >>
> >> There's a bug here which we need to deal with one way or another.
> >> May I please ask for a response to the issues pointed out with
> >> what you said in your earlier reply?
> >
> >I sincerely hope we won't ship another major version with this
> >issue unfixed. The only option beyond applying this patch that I'm
> >aware of is to revert the commit pointed at by Fixes:, which imo
> >would be a shame (moving us further away from proper PVH support,
> >including Dom0).
>
> perhaps another item for the list of things needing resolution for
> the release.
Many thanks for this information! I can see this thread is quite old and
probably even before I became the release manager so thanks for your
effort to find this :))
Yes of course, I've added this series to my blockers list and I will start to
track it so that we can have proper resolution for the 4.17 release.
Kind regards,
Henry
>
> Jan
|