[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86: deal with gcc12 release build issues
- To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- Date: Mon, 18 Jul 2022 16:11:05 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DeR1xM9clxPThvwIwRFyrGWtoRsfan4gQ1Xe+sIld+s=; b=OcEnG+eWXHgIIE5byKbHNnImUet6ynYyfuh+vfNwYF84hkLi2eHKivWW63FNCFcd0F7TFnUfTATXjVofOoviwxhueNUpm1MJ1fuvCuwD+zOJML9O34EW0S/34N9XEiabShHZ86XwHQHglOFzGclyT15ph7Hv40kGjlhowTMKYMkip8UgLYUmMEuouGWS6WdmwF57Bx7R4JGzpc9Wytkdz4XOiavBZa4qtrdeUG8G9dNnmxiDDwvmyJI9/5R5xg4xPGjEHaIFI3CvVgtRoYhiz4zwLDAMmRjf3p8e+hqg1KrQ/faElHD1p9K6kMO7iW5Iq4VHA9/dL9ym5J9a3I/8sg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iJ0e8pKS7CfV0WnGZ8KR7HYvyn2eOjKlDXXM557iWyTqwxAwN6LjpLbZOBFiqgwCnD/9qa7x4qgel87dOzrPc51736vOoIp5FznVmNk+cb+Vzg5MHlI/MHWmQp5yvFvPQ6I0OSYNij9BnBNaELu6wDt+hpuguyIuPXytlE7KcL5lujyBi8X8Uhbf9hM9RIBGbbtxna38WdVsEcS4ltxS1ObyoPhQX80mW7/rZa3pLDiVcw/ua7ay1XWKw44VhOGM9Hulrpvg+YsHx0U7co7HWjVZe8+go0MvdIDs+433TPay50j4WrapfWy1r1EVmP+6sOPyPTQkGL7ZCnmuv7WfxA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Wei Liu <wl@xxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>, Charles Arnold <CARNOLD@xxxxxxxx>
- Delivery-date: Mon, 18 Jul 2022 16:11:15 +0000
- Ironport-data: A9a23:7Ux5yqPi5tziBiXvrXNrnJZpQ6imJRDwMBigOpGNyHHe1HtQZ0Fdl8jBgIlaPhxqb1M5WdDwY4xejPwS9Vsfw+ietHj3SKQK3JpmGPdIPltlpT3G7+RCZoHPael36cmn1uumB/ZKOT2nDS9tFgZEpQGawSeZHMqYOaYuw1QgxKcRUGBcHRnj/2Nh8u5HlXShmjky2u5fISE+050GTm+1YyHu2ZdP4rVnOBMcAn4nwfcYhAlWGQXPimHgBL4LGrP982jvWsTRKFGbCnmc2zwrRP6KOMtRhUQT3VCwS7+rcqQqrjpzJyIasH4RnfL6ev4LrFjRk7LY94pXms6dxxvt2anvRwFgjX4c3biG+xofEmWBy6Kknw40+06FrT0m+VAAJm5SwL3i3g4uBeIvCII0VICOrQDNFw30p8qKkl9imD91GoxeGMkR7iYwGQpY7nnLY/mKFTf7+73vy7FmZ2i3A8FUpGmYu3BF6Q46TDbu6eDbsSl6I1bs5G671w+NeTJs/Jcdmjcs3vDyheFNigKPJ4sHUe4SgxQ5QWT7eg35BE29t+gUIslHsHJd9iZUz2uGrpC1c0lfajnt1trfLMo3UY5wZewwNQqlx/i8J69wD1JQd1Yuisbr6GIKoOmZbo3kC4g6oltJVwl+Nt+o0ECnC46eADE3JVWNY2hMQPne46nS+k7LWnXxgzAiKn3NjNq3CBPufLdhzINkkwoFZ7zZnPBeakge2opdlmiZxySZtcuQRZYWGM/ZnwGweymfb/GIzW2Iu8HX/0OnzxHey6Edh3KstJxYE2goW1lNZdjp4mZucW37UXj9lvN1gOju7z9bR/PCS6iMWeXO9w8+WJpPgf5Mf1+RDvVil5K7Y9vVeYEnSiJwEvxSxKZuBJfOHgShIZxETyofBB10LAWKiqDysCmlWpzU04TFg9wzYJMzFFli2M0aS/P841b47M4Javf/wdUKpGj1XJ+7OtKJ2PF/KKvTPb7LYcm8IlTyHL2ZhPUye02B8Ym7cjTt0zHqYh1K5oaCyIx0dqy4axGXVZKyk18H7n/Ut2WP9eZu+fABmt8pLivDhUuA7Oj1OmbzggoZ/MxMEmS5xtH6Ryqva+h2O4LsKEplSP1mQOv7g4VVSrPzocdc2oPZ1NRXm9HF76jWNCwBHFFf4aPVW4PeQtvtnPFpKIeLWlwvALMGzArE0wFt6m2BO+6oCznaJ3lNRxfVqQRKlquTICdbdM/kHvMy2Jj3s31+HaATVj+unqcD+Ynsy2LY1xYVpJ+n9qmyOH3LQn4822DGRq0ouxdYn3UVjoOdadXqXhwggtY6wHHE3I5cKMm3u6TW6+R2u/6Eh5sIOHA/AksOpLAESHsGbiHjPpo+gSg3NgpT6S0xlgFdtmZ6jkJh/5k9y8mMQ6o4d98/ifzbkE54U0OrBpphSnk7AYFzdMkK1wAZrqo+SiBHJzTc8RY3K+jfkUac2vIcwYXF7aALFqEZdVJDa7s2/dxyH3rIoYjGysWaTkB5XL5eW7YLPHP+fGDU5Ky6e+nn1g6F4a81umr+o1iD7IIqPKYeIjOKRJoLqrPM0HnWfGYrr/W17eAlxZ6ceAUZVtT3Jci3mIYrVamXnsVtyGYV5ETbk/9CpJQYIsMtYR5K4Sjt+yqVdHffgRMPrZX3w0Vismhw0X2LdOn3p9AtgkMRx3MTgPqiVurKTJyglZMVVrGDhYfht/+jQNXFtikkiKQCkCGUaMCzwphLCYwj5Jvd3KTdH2a/WqHvLFkaKY/cbFFUaQbXUEVKYzHQR9sNTst7B+UfKTSaaeqw36XIIBUksATis4paqRbl3JMXTC4n/4bn1vxksglRXiuyRXReOHr+JQj4nhU7NLp48jdHJlhugXdv77+XOoigq6DpSp3xz+lXHdHXjZwLiSjVDMUqpTIjQEFkVJUHy/ZyU31LClPB7zUBue5oWq46nuZn2uTcpgDJeXFQIpX0WqSJMFXpj5qxPqlKFWnBGIA5ngGGPQPCBtZ8v+hoU4B1mdeGrz8BjsIGe88SMLhCblMHE764TYbMAbO/+/OMGTR7bq6kd5bkbMcBayYWlrnD1Mry3zO9mWtNW3qkQgoq7FF6bUtkzXtn+ohML6d7/wEJQHSPxHXQYUefyvCGE6JvNIrnxwjaQZOF56JOSAKxLDzLN4zxX1q8oyyhlDFUI23GQVZ7DgNfEO6AnhJMaiuBGF1Auw4/3s00gxyVLM40DGPGpiYQGsXtL8gvkjC0gORR8Debvw6hLbj2bTsa7iB1kgyO6x88cFhvT2ttwZkWZlDeCLfHDxWrg/jTfO0t9tvgrhLegjQH6GtvWUjmqhFiwSxFIAw3GQSMRZI/ytviY+xIALdBujk4EBZW2IfI45qNEdHcUZEoT0VsdEu0eqDVJV8mlBoeFHRBUeMfvWyRZFKnGyxHt/mQ
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHYl1bWGTbUX0llkEufEOvvIzdFiq2EU0cA
- Thread-topic: [PATCH] x86: deal with gcc12 release build issues
On 14/07/2022 08:53, Jan Beulich wrote:
> While a number of issues we previously had with pre-release gcc12 were
> fixed in the final release, we continue to have one issue (with multiple
> instances) when doing release builds (i.e. at higher optimization
> levels): The compiler takes issue with subtracting (always 1 in our
> case) from artifical labels (expressed as array) marking the end of
> certain regions. This isn't an unreasonable position to take. Simply
> hide the "array-ness" by casting to an integer type. To keep things
> looking consistently, apply the same cast also on the respective
> expressions dealing with the starting addresses. (Note how
> efi_arch_memory_setup()'s l2_table_offset() invocations avoid a similar
> issue by already having the necessary casts.) In is_xen_fixed_mfn()
> further switch from __pa() to virt_to_maddr() to better match the left
> sides of the <= operators.
>
> Reported-by: Charles Arnold <carnold@xxxxxxxx>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> ---
> Initially I had considered introducing something like END_MINUS_1(), but
> in the end I did consider this uglier than explicitly dealing with the
> two instances we have.
Yeah, I prefer this form.
Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
|
