[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86: log non-responding CPUs in fatal_trap()
- To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- Date: Mon, 18 Jul 2022 15:55:35 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MSI97MrQotepVKNN0FluTnsWY1D418cR39DIgXmWB8I=; b=L3w7iSEiUIbsQKeE1qpDp4Mfi8L+2L0af5YLYLqEqq+bHMSXu5JO3uu70QARx1Mz1EuZ5LDOx8WBV0sUX4DqxSgnHZA6jMRMHmoqz3ALtL+QT8io/qvL/FprsMDHkLpSuVibX75t3/2YTXCFJzi56a7cstFbY/76XO62mIPSV/KFYyGhPHTMpGTS4zQddQ0NJiAoOO6FYtQW+YqrW6Bb+rcr9Xau5OUpzkTUajbYMJhhVx7x5Az4Ig9iiAA8OPpm98tnhw1Uiz1RJLGcOt1CZY2tF/SWs6oNnQrMhwEsJZlYXnFZhWnFDJX+VAnyxDhmzDsITf2F/neecabPF1E69Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Le7jHFR8LkExmaXEczkH2ZMbTWF4s38b0uv/G3Am6cuoyyXpCtFvBzqnBcpz0i5VHqW/SHpOqXpj8wuywUMZaG5WpBHSnkFobT3m9ReB5ObWL15tWxa5kcGUfZbon4EnoGQ2x7uWjvtmBG1YYYvIYDc/JiEzCXw9HMf8WpjvVHsAV4gWcspyUkGEmPHW1FX+rwFW6kcnJaODVR8pbQm8PZPAGHElrwlVGjf1AdzxhsG2kyBDU/ARNAJwtnU1IOkM+1O2XsAZsy584/L4D1BpXMEFqxng8/1uPtthIgXo4RhEskwWSMMXdrapT9tUEo+3hv62wzR5hN0y/yidX93eBg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Wei Liu <wl@xxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>
- Delivery-date: Mon, 18 Jul 2022 15:55:53 +0000
- Ironport-data: A9a23:PY7ZUaJk89FUfXZFFE+RyJQlxSXFcZb7ZxGr2PjKsXjdYENSgjEHn WJNCDqAM63ZZmGmco1+Oti180NT6MfSzt82HgplqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s q3yv/GZdJhcokf0/0vraP65xZVF/fngbqLmD+LZMTxGSwZhSSMw4TpugOd8iYNz6TSDK1rlV eja/ouOYjdJ5xYuajhOs/3a+Es21BjPkGhwUmIWNKgjUGD2zxH5PLpHTYmtIn3xRJVjH+LSb 44vG5ngows1Vz90Yj+Uuu6Tnn8iG9Y+DiDX4pZiYICwgwAqm8AH+v1T2Mzwy6tgo27hc9hZk L2hvHErIOsjFvWkdO81C3G0H8ziVEHvFXCuzXWX6KSuI0P6n3TE2P5LM34OY6gj99lpEHFit uQJNxMscUXW7w626OrTpuhEoO0GdZCuFqVP/3ZqwHfeEOosRo3FT+PS/9hE0Twsh8dIW/HDe 84ebjkpZxPFC/FNEg5PVNRiw6H11j+mLWwwRFG9/MLb50D6ygBr3aerG93SYtGQHu1en1qCp 3KA9GP8av0fHIPBkWffoi337gPJtSjfetItEqaDz8dzhUSYy0YOOQELd3Lu9JFVjWb7AbqzM Xc8+CAjsKwz/0yDVcTmUluzp3vslg4RXZ9cHvM37CmJy7HI+ECJC24cVDlDZdc68sgsSlQCy Vuhj97vQzt1v9WopWm1876VqXa4P3gTJGpbPCscF1Jbsp/kvZ05iQ/JQpB7Cqmpg9bpGDb2h TeXsCw5gLZVhskOv0mmwW36b/uXjsChZmYICs//BwpJMisRiFaZWrGV
- Ironport-hdrordr: A9a23:4bZ7T6Csvic8zuDlHegPsceALOsnbusQ8zAXPh9KJCC9I/bzqy nxpp8mPEfP+U0ssHFJo6HiBEEZKUmsuKKdkrNhR4tKOzOW9FdATbsSp7cKpgeNJ8SQzJ876U 4NSclD4ZjLfCBHZKXBkUaF+rQbsb+6GcmT7I+woUuFDzsaEp2IhD0JaDpzZ3cGIDWucqBJca Z0iPAmmxOQPVAsKuirDHgMWObO4/fRkoj9XBIADxk7rCGTkDKB8tfBYlml9yZbdwkK7aYp8G DDnQC8zL6kqeuHxhjV0HKWx4hKmeHm1sBICKW3+4gow3TX+0WVjbZaKvi/VQMO0aWSAZER4Z 7xSiIbToZOArXqDyeISFXWqlDdOX0VmgLfIBej8AfeSIrCNXwH4oN69PxkmlGy0TtegPhslK 1MxG6XrJxREFfJmzn8/cHBU1VwmlOzumdKq59bs5Vza/poVFZql/1owGpFVJMbWC7q4oEuF+ djSMna+fZNaFufK3TUpHNmztCgVmk6Wk7ueDlIhuWFlzxN2HxpxUoRw8IS2n8G6ZImUpFBo+ DJKL5hmr1CRtIfKah9GOACS82qDXGle2OFDEuCZVD8UK0XMXPErJD6pL0z+eGxYZQNiIA/nZ zQOWkowVLau3iefPFm8Kc7giwlGl/NLAgF4vsulKRRq/n7WKfhNzGFRRQnj9agys9vcPHmZw ==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHYloTvaSPt93x0vkCi/J1tzLTyAa2EUJcA
- Thread-topic: [PATCH] x86: log non-responding CPUs in fatal_trap()
On 13/07/2022 07:51, Jan Beulich wrote:
> This eases recognizing that something odd is going on.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>
> --- a/xen/arch/x86/traps.c
> +++ b/xen/arch/x86/traps.c
> @@ -845,6 +845,9 @@ void fatal_trap(const struct cpu_user_re
> msecs = 10;
> }
> }
> + if ( pending )
> + printk("Non-responding CPUs: %*pbl\n",
> + CPUMASK_PR(&show_state_mask));
Prevailing style elsewhere is {%*pbl}.
Preferably with that adjusted, Acked-by: Andrew Cooper
<andrew.cooper3@xxxxxxxxxx>
|