[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/9] xen/x86: introduce a helper to update memory hotplug end
- To: Wei Chen <Wei.Chen@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 13 Jul 2022 12:03:05 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Fth4OO6y5ab5pQnHrZZLzi5dJ8kW/sbdlMjh3d2qqoc=; b=OjOjNmZJGMtMcOEAmrk6ZrNdMiihCfrXdLtpmlGWc5Z9RrT2Q640qnepHni7STWDGYg1ZKNXRpA+Sh197NvKUz77IHJ3veo9WHPDBi3tskH4D72RPbOtdaBbAOekv6QlGFthxbcs5ery8dGAoZU4Mbo/Fzali5k968VLmTdFpwNTNgG9yQoLlI5TcwZpjsjRP5IDK/MHuL0DPQNUFITbpY3WNPOqf02sbMKCkog0zTeNkQz5TdTlzdQ58plYo/T7CrHQlEjC5vvOCeIDwYVhh7p3afzlOJ8lwOvXYy7Yv9vAs6i9IBStlZowKC8lchAmF/4vPZT6uhZIrZCyNfY9Iw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fsEN+TQfMI8/ljIhkGSrJvsHPNLEHR1Daq+TrDl/x4alfMQiS1SqkKoiOGp0A0iIurQR/xV47xy3jSJD0DCV8qpFwMCS2nTMCPb/9VvN7Kt95cbXAbOAPXSHS4m32kswirnqkYZbj+8TjhvJsUZu8hQ92C25TBccsUPguQoWBsiwNIbimq8OGP3jh6dE+BNRsbeJcJI7qGayngauAgyOGzD+dfBW4MZEUW5T3VtvHiJzvE6eyF47Ja81pxVFxXmz9MN5rYsFQbMGfVPrNVnujgsInHeVmlSVJCOoEt7LDAMwFklx75zgIcU91C+Afu2HgZKtL7MJAiYYeeJkEifxRQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: nd <nd@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 13 Jul 2022 10:03:18 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 13.07.2022 11:55, Wei Chen wrote:
>> From: Jan Beulich <jbeulich@xxxxxxxx>
>> Sent: 2022年7月13日 16:46
>>
>> On 13.07.2022 10:22, Wei Chen wrote:
>>>> From: Jan Beulich <jbeulich@xxxxxxxx>
>>>> Sent: 2022年7月12日 19:54
>>>>
>>>> Mechanically the change is fine. Albeit maybe "top" instead
>>>> of "boundary", and maybe also pass "node" even if x86 doesn't need it?
>>>>
>>>
>>> Sorry, I am not very clear about these comments:
>>> It makes sense to use mem_hotplug_update_top instead
>>> of mem_hotplug_update_boundary. But how can I understand pass "node"?
>>> did you mean mem_hotplug_update_top(node, end)? But mem_hotplug is
>>> a global top for memory hotplug ranges. I don't think pass "node"
>>> to this function can be useful.
>>
>> Please separate "current implementation" from "abstract model". In the
>> latter it would seem quite reasonable to me to have per-node upper
>> bounds (or even per-node ranges). Therefore adding node (and, on top
>> of what I did suggest before, region start) to the parameters of the
>> new per-arch hook would seem a good move to me, even if at present
>> only / at most the "end" parameter would actually be used.
>>
>
> As we will export mem_hotplug to common, I think these changes are
> not needed any more?
Indeed. I merely wanted to address your question nevertheless, or in case
there was still a reason to avoid making the global variable common.
Jan
|
