[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] x86/spec-ctrl: correct per-guest-type reporting of MD_CLEAR


  • To: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Wed, 13 Jul 2022 09:52:39 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iOiGbfV0z5lZIUjOxHbBoyRhAmtUY9YeW/L9Ese30/k=; b=GZ/VZE7aYcBNWY647LWd8Lo4fvIUmD6w1Fo+/bB+uRKq9+BkpAWSJizZqnL2Lx3kxnGM2ntgtVYdFX73AQITFCf/xZtSNgHfkNp5t0/T/9pSqRBRbthYNVfIR7LIbyS/wbIPYDMOFA8cwCguqFVxnRkPODK6MUw0CZ61EHV8mrdYNkD2Nt+JxC2ZWtYaYEvUKH1+2GRrnn4ecZvSNioEduSia0snmmUjGvbdkoZw+d0OCwt2v5/QvF3zHatSJiN26RT0EvOS9/DUzLY88IhJDzvOrul8Zc2e7q9CPND2xQsbA7yXJ7LZi77exqd76S2eyn5Dwf68z9IAEPdeBVGBEA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=idKraY9MTXwsb508N1TMlisKsOzDa2b0VTsx4zA7GZ/2SvMvwLzEdSujBw37KGumCOV+FprrVhpggPKviZ9Ag5K0FUwfep4c5rH9g+eCrqa3sQ+Ham7RHKnsYuONENQubw2fZv/FYoOvBTSjelZT0vVLivzQt2XODObe8YO5XR4lvZbKAaIiexCQOivrJI0WqcSkwTup7/A2mHJhfPneFNETth8jc5gQ92dQZVCzCzND19frecfDwnBXimRmj6oEcXJv7t+BVuwMNIPgI1wnCZaRC4gm306/y/8aAjadOnwoL2YYVrNRb4Rs+FcEdfhVsT04aIiPBh3B1dsO8rF09Q==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Delivery-date: Wed, 13 Jul 2022 07:52:56 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

There are command line controls for this and the default also isn't "always
enable when hardware supports it", which logging should take into account.

Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

--- unstable.orig/xen/arch/x86/spec_ctrl.c      2022-04-13 14:29:38.000000000 
+0200
+++ unstable/xen/arch/x86/spec_ctrl.c   2022-07-13 09:38:44.012913760 +0200
@@ -511,13 +511,12 @@ static void __init print_details(enum in
     printk("  Support for HVM VMs:%s%s%s%s%s%s\n",
            (boot_cpu_has(X86_FEATURE_SC_MSR_HVM) ||
             boot_cpu_has(X86_FEATURE_SC_RSB_HVM) ||
-            boot_cpu_has(X86_FEATURE_MD_CLEAR)   ||
             boot_cpu_has(X86_FEATURE_IBPB_ENTRY_HVM) ||
-            opt_eager_fpu)                           ? ""               : " 
None",
+            opt_eager_fpu || opt_md_clear_hvm)       ? ""               : " 
None",
            boot_cpu_has(X86_FEATURE_SC_MSR_HVM)      ? " MSR_SPEC_CTRL" : "",
            boot_cpu_has(X86_FEATURE_SC_RSB_HVM)      ? " RSB"           : "",
            opt_eager_fpu                             ? " EAGER_FPU"     : "",
-           boot_cpu_has(X86_FEATURE_MD_CLEAR)        ? " MD_CLEAR"      : "",
+           opt_md_clear_hvm                          ? " MD_CLEAR"      : "",
            boot_cpu_has(X86_FEATURE_IBPB_ENTRY_HVM)  ? " IBPB-entry"    : "");
 
 #endif
@@ -525,13 +524,12 @@ static void __init print_details(enum in
     printk("  Support for PV VMs:%s%s%s%s%s%s\n",
            (boot_cpu_has(X86_FEATURE_SC_MSR_PV) ||
             boot_cpu_has(X86_FEATURE_SC_RSB_PV) ||
-            boot_cpu_has(X86_FEATURE_MD_CLEAR)  ||
             boot_cpu_has(X86_FEATURE_IBPB_ENTRY_PV) ||
-            opt_eager_fpu)                           ? ""               : " 
None",
+            opt_eager_fpu || opt_md_clear_pv)        ? ""               : " 
None",
            boot_cpu_has(X86_FEATURE_SC_MSR_PV)       ? " MSR_SPEC_CTRL" : "",
            boot_cpu_has(X86_FEATURE_SC_RSB_PV)       ? " RSB"           : "",
            opt_eager_fpu                             ? " EAGER_FPU"     : "",
-           boot_cpu_has(X86_FEATURE_MD_CLEAR)        ? " MD_CLEAR"      : "",
+           opt_md_clear_pv                           ? " MD_CLEAR"      : "",
            boot_cpu_has(X86_FEATURE_IBPB_ENTRY_PV)   ? " IBPB-entry"    : "");
 
     printk("  XPTI (64-bit PV only): Dom0 %s, DomU %s (with%s PCID)\n",



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.