[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 7/9] xen/x86: rename bad_srat to numa_bad
- To: Wei Chen <wei.chen@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 12 Jul 2022 16:25:32 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JnGDZCiSKW2A8fPt4iaXqGq0kr2RHdUx6hd/eh7V5I4=; b=fqL3e38sfoOxwGnq+Q5jnsQQMZvVObJ+NgnpDjvGW2Hg6I5xN52HamSDWiJUcM2pi4wo6CbhRjzL0zLjNssC3Ge/WOBPdD8k2B1dvCX0euinPmFWLdYu20I3e1W1XLMbWV/u/QCYZIuhKhT6w5iFmRovLxom8M/rbQWN1XRgEaDILT+I7R2doWR7ylf0fOS57r8n1yZYky1eQIFu9Dh9/2xG6Mw9tdMvJ2vYVL4ZylDwtY8NoK35IQ+0DFTnQucVBNo+p/ZFJtE/+lPEZhEu5Re7jhM3XrFXYGQqwY9y3cs6wd57OftMDddXaR3zbopllIBl8EJKd9t1dkqAcFaZ+Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=blc8Qvcg1AHbe72T+m+trXu8MLQuWys2dmHnyAXohS9rfkmUsv4ZoXw6C7eV169wL2aPDx1Sv4lqvFTt20UeU6TjBYene6Z8+82oEtMg3mZjHA4kqPhAtLrW43XJNxTg92tmTUYNEn7q2DqewW52aAhpi2SpztyQh715qWrrNGVuRqJ1RyeiDFgq+vFFpnAFLUB640pRJlTJEdIx4tWac/J9pHF7grZuyZnZptudAvDAU1NwX1kkl9pLs+U24Pk6Bcrwqt+mlnRaS2uQa4EXRbUJfag3mOg9MK+xFWhe+i3paDoqWEJRUeVBGdWpu2zpR/k1cDs9PPi0Hn5bVuGtkw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: nd@xxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 12 Jul 2022 14:25:41 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 08.07.2022 16:54, Wei Chen wrote:
> When NUMA initialization code is failed in scanning SRAT. It will
> call bad_srat to set disable NUMA and clear relate data. But this
> name is ACPI specific, we have moved generically usable NUMA codes
> to common, bad_srat has came with these codes to common code. But
> it's not reasonable for other NUMA implementations to implement a
> fall back function named bad_srat. So in this patch, we rename
> bad_srat to numa_bad.
>
> Signed-off-by: Wei Chen <wei.chen@xxxxxxx>
> ---
> v1 -> v2:
> 1. New in v2.
I think this wants to come before moving to common code. And I'd
also like you to consider using e.g. numa_fw_bad() or
numa_firmware_bad() to better reflect the original purpose.
Jan
|
