[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen/build: remove unneeded enumeration in clean-files
- To: Juergen Gross <jgross@xxxxxxxx>
- From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- Date: Mon, 11 Jul 2022 17:36:45 +0100
- Authentication-results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
- Cc: <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, "Jan Beulich" <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, "Stefano Stabellini" <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Mon, 11 Jul 2022 16:37:09 +0000
- Ironport-data: A9a23:AakqIatFUZPA/2IJwxb1nqE5B+fnVF1eMUV32f8akzHdYApBsoF/q tZmKW+AOPmMZmuhfIp2aNni8xwBu8eGn9U2QQNorS1kH3tA+JbJXdiXEBz9bniYRiHhoOOLz Cm8hv3odp1coqr0/0/1WlTZhSAgk/nOHNIQMcacUsxLbVYMpBwJ1FQywYbVvqYy2YLjW1zU4 IuoyyHiEATNNwBcYzp8B52r8HuDjNyq0N/PlgVjDRzjlAa2e0g9VPrzF4noR5fLatA88tqBb /TC1NmEElbxpH/BPD8HfoHTKSXmSpaKVeSHZ+E/t6KK2nCurQRquko32WZ1he66RFxlkvgoo Oihu6BcRi8JLJTJlMohFCVnGiBsYJdA/bjAGSKg5Jn7I03uKxMAwt1rBUAye4YZ5vx2ESdF8 vlwxDIlN07ZwbjsmfTiF7cq1p9LwMrDZevzvllpyy3ZCvA3B4jOWazQ6fdT3Ssqh9AIFvHbD yYcQWUyPUqYO00VUrsRILIbjsCn12TfSR9BhFuKnIkt0U//8gMkhdABN/KKI4fXFK25hH2wp H/C/mn/KgEXMpqY0zXt2mm3mubFkCf/WYQTPL617PhnhBuU3GN7IAISfUu2p7++kEHWc9BQM UsP4QI1sLM/skesS7HVTxC+5XKJoBMYc95RCPEhrhGAzLLO5ASUDXRCSSROAPQkvsIrQT0h1 neSgsjkQzdotdWopWm1r+nO62noYG5McDFENXRsoRY5D8fLgJMKix7hcpFfL6e0nIDPHzT3x AjQs31r71kMtvLnx5lX7Hie3W/z/cCTE1dsjunEdjn7t10kPeZJc6TtsAGGtqgYce51W3Hb5 BA5d96iAPfi5H1nvAiEW60zEb6g/J5p2xWM0Ac0T/HNG9lAkkNPnLy8AxkkfS+Fyu5eJVfUj Lb74Gu9HqN7MnqwdrNQaImsEcksxqWIPY27C6+IMYoXPcQgLlPvEMRSiam4hjqFraTRuftnZ cfznTiEVx729piLPBLpHrxAgNfHNwg1xH/JRICT8ilLJYG2PSbPIZ9caQPmRrlgsMus/VSOm /4CZpTi9vmqeLCnCsUh2dVLfQ5iwLlSLc2elvG7gcbaf1A2STF/W6+MqV7jEqQ895loei7z1 inVcidlJJDX3BUr9S3ihqhfVY7S
- Ironport-hdrordr: A9a23:8ih1Z62hphZust2bf9kAPQqjBLAkLtp133Aq2lEZdPRUGvb4qy mLpoV96faUskd0ZJhOo7y90cW7Lk80sKQFh7X5Xo3SOTUO2lHYT72KhLGKq1aLdhEWtNQtt5 uIG5IOceEYZmIbsS+V2meFL+o=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Mon, Jul 11, 2022 at 12:58:40PM +0200, Juergen Gross wrote:
> Enumerating a file from $(targets) in $(clean-files) isn't needed.
>
> Remove xen/include/xen/hypercall-defs.h from $(clean-files).
>
> Reported-by: Jan Beulich <jbeulich@xxxxxxxx>
> Fixes: eca1f00d0227 ("xen: generate hypercall interface related code")
> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
> ---
> xen/include/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/xen/include/Makefile b/xen/include/Makefile
> index 39d9f5556c..fa0d454ab7 100644
> --- a/xen/include/Makefile
> +++ b/xen/include/Makefile
> @@ -225,4 +225,4 @@ all: lib-x86-all
> endif
>
> clean-files := compat config generated headers*.chk
> xen/lib/x86/cpuid-autogen.h
> -clean-files += xen/hypercall-defs.h hypercall-defs.i
> +clean-files += hypercall-defs.i
The patch title is a bit too broad and only correct a recent patch. It
doesn't really matter I think if `rm -f` tries to remove the same file
twice, but maybe this patch should actually do what it is explained in
the description ;-).
There is also "headers*.chk" that is listed in both $(targets) and
$(clean-files) which could be unlisted from the latter as well.
Thanks,
--
Anthony PERARD
|
