[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/4] xen/arm: domain: Fix MISRA C 2012 Rule 8.7 violation
- To: Xenia Ragiadakou <burzalodowa@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 6 Jul 2022 09:10:25 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CD9/NiGIUt6EuxRGUHKkxxWTlFzw9ckhYkOJsrDL13g=; b=SRzKcSif/1GiE2FS86I8rolqgzHiIAevA7eefBIR5V3wwL9RM2P7HwAqeX6MGAHH/sqdV5kLokY4/P5d0qa4oBE13qWMyGAbjrNkOmhlYRUzwUhWAwMcbiVLTyWU5vdJjY9TYLCv9Fdpg2cXCZ0+tHvX+1TRK+kMphNnQR6Tlf/xmeeV2TWtjw5gu7XcFstuM142E9sLTUp+wiMuXGfs52zBtrIxv+K6wlWrhbifabYr+vNVvhP1pVwQnTOHhZK2VjV9rtjf889usu2vN7ruJrTzVoa9cXyypgIo/Wp9SLQ+Aun+wLpHnNc9ADhUgjLRw56KYIaCDrLhQxNcy/n3nA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Fx1oJqFt9za+wtjWZeK1kd9uNoRo21+Qi6eJuRSpRqV5JaEU5/jdXw0QP0FpATTRQ07PCN6NTCLHqh1ylQ7E8ybnUTu0TRDhAq+nrlfppSd19mceLum6TLUdHD1OAoOy+5srcV2l9UuekWH/PxVvUj1ZTynduF8tq6BNJHB5KkAP3Z9/xhM6lhB9GEhfJaCKfCpBksR6hlLfRLO1jq6Vy93qGVKhE2GkjROG4wLRTkcLaKcwlGHetbuU6AlNZ0DBaAKSkuXkpQjHadKwdqa4Sn6vKlh/BDnFWhwRb8kRR6RQz73MQ7heJ/j26evIYRNOM4NNYgFqiphtlSKEhPJMcQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Wed, 06 Jul 2022 07:10:43 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 05.07.2022 23:02, Xenia Ragiadakou wrote:
> The function idle_loop() is referenced only in domain.c.
> Change its linkage from external to internal by adding the storage-class
> specifier static to its definitions.
>
> Since idle_loop() is referenced only in inline assembly, add the 'used'
> attribute to suppress unused-function compiler warning.
While I see that Julien has already acked the patch, I'd like to point
out that using __used here is somewhat bogus. Imo the better approach
is to properly make visible to the compiler that the symbol is used by
the asm(), by adding a fake(?) input.
Jan
|
