[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] livepatch: create-diff-object: Check that the section has a secsym
- To: Sarah Newman <sarah.newman@xxxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 6 Jul 2022 08:54:13 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OcNK1E2+WvdMepGilGPDMb4jUR7+vQTyafiJd8TY0+4=; b=SX+xPxw1f5ABf3w8hiHrkmTH2m1WMsGgPe6QM4TWYTw9S0R4v77AbsFu4dzzSU4RD0g45t6KvWJ7vi9Av7Zm/BCbqSTX6CUJ1TlHilcAFDNKDMBW0RXxhcYlElXDZMlDL4XDzQdXr0+CogESIpHs4jW8PQl6xx/5jpF6Hf4GpFED0bdxLf/0FolOTLVF4Mn5hGZ4xGzM1iEHu7A0fbjo7kkhSFcyWYYSJHoG1Cr6JtHhGacL4apNbhaJ81w+eOOUvOkNakixfGLa3lYqJ8NAcCdgDiEA0ae3BPDsQzpqIrYAeawUrohMWD1RrsxLR1iE3T0iK6V9k+M1XzVmH7cQgg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e8/9IwHtVNyyMmS/p0LLK270MTWpQlBeXaE2q+l6UPYJPfSXXfSRZ9lvqw+4WPI5Q66TTlZR+1qGcaQdcsYOy548Ywxkj0zEG7O05KDUnB/YfgZntIJzIFAPLN/aEEFrXDpqU7ACS74/HiB2ZwEesuzEPnD7INgD0JdrZjX+tKF55t1qVyozzVrakZhCY5+tsvrw01CtO+Slpd92jooDLZ4CJQMnTJmNziheOwPG5CK7klMhJ5Ktv7TMxLKEBRiGBuig/VTZNfE0GQ8MQa7rM96dKhn8k6I7ArRWpu3ktcw84sy7tRs04CjJKMgERLimhRloZ8uThM8v7Z+/OBC+4g==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Xen-devel@xxxxxxxxxxxxxxxxxxxx, Konrad Wilk <konrad.wilk@xxxxxxxxxx>, Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>
- Delivery-date: Wed, 06 Jul 2022 06:54:38 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 06.07.2022 04:18, Sarah Newman wrote:
> A STT_SECTION symbol is not needed if if it is not used as a relocation
> target. Therefore, a section, in this case a debug section, may not have
> a secsym associated with it.
>
> This is a livepatch backport of kpatch upstream commit [1]:
> create-diff-object: Check that the section has a secsym ba3defa
>
> Signed-off-by: Sarah Newman <sarah.newman@xxxxxxxxxxxx>
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
However I think the 7-digit hash above wants either extending to at
least 10 digits (better 12), or dropping altogether for having the
full hash ...
> [1]
> https://github.com/dynup/kpatch/commit/ba3defa06073dcc69917dbbbb9df570ca4e56612
... here anyway. But I guess the rules set forth in
xen.git:docs/process/sending-patches.pandoc could be applied here,
and hence an Origin: tag would best be used.
The other thing is: You didn't Cc any of the maintainer(s).
Jan
|
