[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [PATCH] EFI: strip xen.efi when putting it on the EFI partition


  • To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Henry Wang <Henry.Wang@xxxxxxx>
  • Date: Wed, 6 Jul 2022 05:44:56 +0000
  • Accept-language: zh-CN, en-US
  • Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
  • Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XhGOJ/LgDrJTJvuRxeqPLbmWqef706X4agYcZ0WeL1M=; b=erelCa8FJWqRUxVjS1kxU6Xup7w6v0j0RKHKtGeaIp6mCRGF9JAzw88/ShJYfwSJlPEeMKmZVlM8rmmjhSuSSyz6FxbuEh/FTXDAS63TEoMectMYH7C9VYsoKizZ9BsfDmuRAJtIjazxGgbV5VJFUy/cdkPdaWgAROngJxv+P/16HpnmdVdPpylHI1DZ7kWpv1iu8zllPmOELYDp+2iHq98CcDWQ74swm6HNVGnwQNLqifhGTBccEV0sdyeg0xweGabj4UbWC9MIBefRA7xnN92PEmmLi2hmp+jf5soDlbEj8Yd/n8E6iiXe5xXZf9WqeWwdXOwIpXlfA36sqBkigQ==
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XhGOJ/LgDrJTJvuRxeqPLbmWqef706X4agYcZ0WeL1M=; b=dt7pbAifdRuGWFP+mAVIU6vWsS/f4+d/7tZT3RgsbS+SMnVTXxEQH7SToGBTOO93qTFmzfj02hONlLuQ5XWOS2SFKd5oiwF8VSSALnFXG5EREBNPM45B6Ko7X0RtDtt84WX2HjO4dMZ7zMothuAeGzCO1kd87H+rToHN5Y273bSkDb29z8nHmA8m8P+GTb/n1m5kWQFWQkGvL/6W40jeE3uPy9pbMhRj2MlNx5J6i0A7owNVHLpr9oWeIAxEdIxvoD/6GknBkVup1HAy7a+Pbr59kV5JlyKMh95QhACNzNhq/vZ5s8xP0KtnG6rTQAQ12wo0P3nkLz5Jq6ybdkVVzQ==
  • Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=G4FMcDx0rsttcafVkWKnA6gpiVCTvwDqxsO6k1ZimjPca9TuB3dn299rn45TNPs8zIYlCNPwta7lhobuVRsbjzi9zPOZSskRnrtEGefVGhqcTCK69hh5JMwHdsnx8lrm1Sv7zho8YyrIwxayuTt4j0oDpqSbFVeD15eNh7EUDBaoExPoi17JTKeJZ7mgMNRt1fG/6jAYWoZRSYcD02pP8KbFWiox4vi2uFQ3fIIgqaaMSTJs7D0b4ekas9Xx3iA7f0z/CTVkmYLwmAfaf65O7PeUqU5tOFvhK6lnTsbFIsXMhAPU1svwkb+4TIsaeR3qp2bJ4n5dEnAOQg1oVoXRbg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X5lIAX006YKmjqJl4gCdh8OU/KG9jxkNsJ9NDu2Fs3dpPBXxTQzByK03NWcOG7hZGfD9TSPx6kd9TsMegYPIwCV93eH6o60kwI3YFj3UVOCn5/WlkeEqWAWKJRPScjX4x0tNWBuWxdEGBwycKoNXy5eCdrcHTGlDM1SB8Z6d0oPgkUz5TrpD7o4bwD9m4AytBudcNi94+oP0JRQwnweqr4Eln7zPtNcK0nSXSD560a7Ct4s4M9TwyAI+zsZmiAzsJCUyiB+NxigQVH1neKbSB5NFdBNdV5sWRNQHBDnIxzkr8PnTCv2ehJzO2xcNdzsfZ7RL1Cf0goPaeYEXwPmL9Q==
  • Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>
  • Delivery-date: Wed, 06 Jul 2022 05:45:31 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Thread-index: AQHYfBklLU4Niq38ak2Q5vLM16P6ia1wGWKAgADj0nA=
  • Thread-topic: [PATCH] EFI: strip xen.efi when putting it on the EFI partition

Hi Jan,

> -----Original Message-----
> Subject: Re: [PATCH] EFI: strip xen.efi when putting it on the EFI partition
> 
> On 09.06.2022 17:52, Jan Beulich wrote:
> > With debug info retained, xen.efi can be quite large. Unlike for xen.gz
> > there's no intermediate step (mkelf32 there) involved which would strip
> > debug info kind of as a side effect. While the installing of xen.efi on
> > the EFI partition is an optional step (intended to be a courtesy to the
> > developer), adjust it also for the purpose of documenting what distros
> > would be expected to do during boot loader configuration (which is what
> > would normally put xen.efi into the EFI partition).
> >
> > Model the control over stripping after Linux'es module installation,
> > except that the stripped executable is constructed in the build area
> > instead of in the destination location. This is to conserve on space
> > used there - EFI partitions tend to be only a few hundred Mb in size.
> >
> > Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> > ---
> > GNU strip 2.38 appears to have issues when acting on a PE binary:
> > - file name symbols are also stripped; while there is a separate
> >   --keep-file-symbols option (which I would have thought to be on by
> >   default anyway), its use so far makes no difference,
> > - the string table grows in size, when one would expect it to retain its
> >   size (or shrink),
> > - linker version is changed in and timestamp zapped from the header.
> > Older GNU strip (observed with 2.35.1) doesn't work at all ("Data
> > Directory size (1c) exceeds space left in section (8)").
> >
> > Future GNU strip is going to honor --keep-file-symbols (and will also
> > have the other issues fixed). Question is whether we should use that
> > option (for the symbol table as a whole to make sense), or whether
> > instead we should (by default) strip the symbol table as well.
> 
> Without any feedback / ack I guess I'll consider this of no interest
> (despite having heard otherwise, triggering me to put together the
> patch in the first place), and put on the pile of effectively
> rejected patches.

I did a test for this patch on my x86 machine and I think this patch is
doing the correct thing, so:

Tested-by: Henry Wang <Henry.Wang@xxxxxxx>

I also noticed that Julien is suggesting maybe we can have Anthony as
the reviewer for this patch, so I also add him in the CC of this email.

Kind regards,
Henry

> 
> Jan


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.