[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 5/8] xen/evtchn: don't close the static event channel.
- To: Rahul Singh <rahul.singh@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 5 Jul 2022 17:33:07 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gMgqu4f335Zue4vhz33R3R//xB2cBoCpftUaPzU/Ubc=; b=hRRKK7bDnZzXF3xXV3RiOYQ64flRgEN6CaxMPi4VdvhDHbwGmwSnv2FWPV/omKlNCnOtxmSQwDFaPW2aUSunIAS8aPwS+ZoNVphoxDmTJORAODG3UyUVQsASZQ316l3Cv4440yH6Y/vKQzhJpb/EN2sp4qQmoDgvQAc4OKsgRW33AqE3orGjoRvuhKCISMppA/OV1+U8xz5EgN6jDP7U6zB7ZgI4uIjhr2PJIIS5HqGFN0RTjQssU1Vi524qvFBqcDOH7jqvqGYb66J4UVPL+J4GpVQL4qhN6SOP9LLnclKfYGT4ZSrPuNMBKOY5lM+DvFCL56B+U7FWgFPKMvfuYw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ksZRUE9nK6L1sVZcdJliFFURnrcs9hG4BoSwAGgFj6npe6Mm71mq+zkPzJd92achHKOEmy8Ea2Fm5V4JrvP/qBY6Accrqm4ViOWxGP6GOiQHQE3njUKrmBqW9Fvd7H4kYtx6w1nc8uWJYjfKbSxytfQa0M/mlVnQk1Ygv6WQAbOVvsxT98dPUhjskobXPHNOfnii2m5ekrAK6kWK9z9QW+gjU5zCdn9OYrkJBtHn93fXsBAkYdFAIIVQdJ+hwzOFjVYuI1dgqvrtmSlYOQIhJN0HY5WS7BUn8ILG9jW30YKYh01JgRvw02zhDMCN2v9jjLwBggEuMk5SmNg601wYvw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: bertrand.marquis@xxxxxxx, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 05 Jul 2022 15:33:20 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 05.07.2022 17:26, Jan Beulich wrote:
> On 22.06.2022 16:38, Rahul Singh wrote:
>> --- a/xen/include/xen/event.h
>> +++ b/xen/include/xen/event.h
>> @@ -73,12 +73,12 @@ int evtchn_allocate_port(struct domain *d, unsigned int
>> port);
>>
>> /* Allocate a new event channel */
>> int __must_check evtchn_alloc_unbound(evtchn_alloc_unbound_t *alloc,
>> - evtchn_port_t port);
>> + evtchn_port_t port, bool is_static);
>>
>> /* Bind an event channel port to interdomain */
>> int __must_check evtchn_bind_interdomain(evtchn_bind_interdomain_t *bind,
>> struct domain *ld,
>> - evtchn_port_t port);
>> + evtchn_port_t port, bool
>> is_static);
>
> Didn't even pay attention to this the first time through: You're
> again touching functions you did alter already in earlier patches,
> and with them their pre-existing call sites. This is not only
> unnecessary code churn but also makes it harder to follow where a
> change came from when (perhaps much later) using "git blame" or
> alike. Please bring these functions into their intended shape in
> a single step (each).
One more thing: Especially "bind" now has quite a few parameters
for which without dom0less (i.e. particularly on x86) only a single
value would ever be passed. Without LTO the compiler could still
deal with this if the function remained static in all non-dom0less
cases. Please consider whether you want to do so, or whether you
want to find another solution to address this concern.
Jan
|
