[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 5/6] x86/irq: print nr_irqs as limit on the number of MSI(-X) interrupts


  • To: Roger Pau Monne <roger.pau@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Tue, 5 Jul 2022 16:15:57 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OJRaAqWCSZDbFVRg2qdHGs4kdr5lV147tVg0bYJvx+8=; b=FRJPmLeHNHlssPOKZ/mr9naXoo/IeDVQyNxRCMU11jI+4LW5KiLTwQ/p3YCXNgF36Z5nQshi0ZlTAk3/h5y0UjQfkR0FnfOUQc0ONaKv6nGbtdxR2PVzqa6HGcOn/2c8m8SSOQ3owc7xxqhMUXb0XRFVah8iFh2xLMkXku/fmfRYHEGz6EcbPk96uERVuf8oCGJAzHLv3z0bTFep+J2l/sSz69etB2amMxkebjCs5VC1/2iSwqHSCHMajLtAfvVbgN/CbWgtRxy7MNgTNkgxsYVwkVvzksJiRPr/9njl72tyY5OsPqwrdJIe+1MNIiBcS/QEuynVouz9zPHC9IG8wQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XL4//Ci6Ac70HvYrvWAU2zK6G0I2QqxxmKgSYd0GfpJ2Ib/le83RBGGq7Kw6BAgZOyXgFvChpi1S7IJWvAKegEk/Ha2nns3c95YC23aqI+tUfZoVOaNl0mUnOT/DLOyRhvcVVLwaSKgcqaoiIf6Bo+WMUhbgsDCVoVa0GVTu+hQbCJbEGgfmytLAg8xi1Gfl6LwZF6lfqnHtE3Lc1uCKS7gCOrRKKmSbFDgQLRHuv48nQpL1MnvkPikcEuFt4lRaE1cuvq3H7y0S1502vuqrZTAIVkJjpVo/bgGME4CvxeDB89uKl9zNxsWkluwpPaVKb8hAxJTWpUrFHWtmKeC25g==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Tue, 05 Jul 2022 14:16:15 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 30.06.2022 10:54, Roger Pau Monne wrote:
> Using nr_irqs minus nr_irqs_gsi is misleading, as GSI interrupts are
> not allocated unless requested by the hardware domain, so a hardware
> domain could not use any GSI (or just one for the ACPI SCI), and hence
> (almost) all nr_irqs will be available for MSI(-X) usage.

Looking at create_irq() I find a loop going from nr_irqs_gsi to nr_irqs.
Similar in get_free_pirq(). All lower numbers aren't eligible for use by
MSI/MSI-X. We can't allow the lower ones to be used for other than GSI
purposes because we can't know whether any device will become enabled
(perhaps long after boot) which wants to use a specific GSI.

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.