[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] x86/shadow: slightly consolidate sh_unshadow_for_p2m_change()
- To: George Dunlap <George.Dunlap@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 27 Jun 2022 08:26:15 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gV1Xq38WoGbki+qQ6AMzWg8y3k6Z0aUHS4+b5ppIr5Y=; b=A7KOdUgETT7qpCyf3tOiRtCfU6g3LMZYUdgNF8o+EZdUCCVaYyiUhV/h7xeL5ZcfeqBteQbMPkKi0i5yUL6QYZInLZMIgiTJZm4Nm2TNMDs+J3Bl8amXp+zEeRxML4kZ8SlkUpGPObhEkuoX6GqxjooqHnLgQDUqRLPpIXtHelP/6qx5Q699/0+leiNn8/MdaIuZuEJ1RaXjwI7RHGFOpo7Iy2ytWTulR//Qebp3BycfHTYZ+7iM7f3/AOQNrqAnMNblE2vXfR6C+9t5P4Que/RyHU8W/+9ZMfXCtdGZW4R8KOweeUY6HCQO1j70Xt3sdMmPFP8Db6I/NMC6oswxpg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AqjxW4W7OHz0rYZiHvtdiXbzI8UOalQaBrs/JG1TU2Cw7TrS4Yoqad2AEenmADVAcgrANA+lNv0bVIrgv5Ei5HZwAP7paEo7H0FFLiHwD5+QNZtaS4Czx78V9U/kwNzcYIxvF7Bjpek1bnHGKsjhSrN6/pd8Oa6jGLuE0WqM3DfWsAVXFy0t6WL39YHtWlIRFu/Kyq+uBRFhQWmISWJxHorLpNUPVuDzfzfHHbVNhQEbaVdd1dApU10Bnwt9sETqHnGr6cb6l123xg5n7oqTK8NA6wgYAyZj+RyxYzlTiOuAF+IpEu5U1tuLTAMKWSLQEi/dnpgV+1/wcTQjBiORNw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>, "Tim (Xen.org)" <tim@xxxxxxx>
- Delivery-date: Mon, 27 Jun 2022 06:26:21 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 24.06.2022 21:16, George Dunlap wrote:
>
>
>> On 9 Dec 2021, at 11:26, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>>
>> In preparation for reactivating the presently dead 2M page path of the
>> function,
>> - also deal with the case of replacing an L1 page table all in one go,
>> - pull common checks out of the switch(). This includes extending a
>> _PAGE_PRESENT check to L1 as well, which presumably was deemed
>> redundant with p2m_is_valid() || p2m_is_grant(), but I think we are
>> better off being explicit in all cases,
>> - replace a p2m_is_ram() check in the 2M case by an explicit
>> _PAGE_PRESENT one, to make more obvious that the subsequent
>> l1e_get_mfn() actually retrieves something that is actually an MFN.
>
> Each of these changes requires careful checking to make sure there aren’t any
> bugs introduced. I’d feel much more comfortable giving an R-b of they were
> broken out into separate patches.
I'll see what I can do. It has been quite some time, but iirc trying
to do things separately didn't work out very well.
Jan
|
