[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 34/36] cpuidle,omap3: Push RCU-idle into omap_sram_idle()
 
- To: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
 
- From: Tony Lindgren <tony@xxxxxxxxxxx>
 
- Date: Mon, 13 Jun 2022 15:35:14 +0300
 
- Cc: rth@xxxxxxxxxxx, ink@xxxxxxxxxxxxxxxxxxxx, mattst88@xxxxxxxxx,	vgupta@xxxxxxxxxx, linux@xxxxxxxxxxxxxxx, ulli.kroll@xxxxxxxxxxxxxx,	linus.walleij@xxxxxxxxxx, shawnguo@xxxxxxxxxx,	Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>, kernel@xxxxxxxxxxxxxx,	festevam@xxxxxxxxx, linux-imx@xxxxxxx, khilman@xxxxxxxxxx,	catalin.marinas@xxxxxxx, will@xxxxxxxxxx, guoren@xxxxxxxxxx,	bcain@xxxxxxxxxxx, chenhuacai@xxxxxxxxxx, kernel@xxxxxxxxxx,	geert@xxxxxxxxxxxxxx, sammy@xxxxxxxxx, monstr@xxxxxxxxx,	tsbogend@xxxxxxxxxxxxxxxx, dinguyen@xxxxxxxxxx, jonas@xxxxxxxxxxxx,	stefan.kristiansson@xxxxxxxxxxxxx, shorne@xxxxxxxxx,	James.Bottomley@xxxxxxxxxxxxxxxxxxxxx, deller@xxxxxx,	mpe@xxxxxxxxxxxxxx, benh@xxxxxxxxxxxxxxxxxxx, paulus@xxxxxxxxx,	paul.walmsley@xxxxxxxxxx, palmer@xxxxxxxxxxx, aou@xxxxxxxxxxxxxxxxx,	hca@xxxxxxxxxxxxx, gor@xxxxxxxxxxxxx, agordeev@xxxxxxxxxxxxx,	borntraeger@xxxxxxxxxxxxx, svens@xxxxxxxxxxxxx,	ysato@xxxxxxxxxxxxxxxxxxxx, dalias@xxxxxxxx, davem@xxxxxxxxxxxxx,	richard@xxxxxx, anton.ivanov@xxxxxxxxxxxxxxxxxx,	johannes@xxxxxxxxxxxxxxxx, tglx@xxxxxxxxxxxxx, mingo@xxxxxxxxxx,	bp@xxxxxxxxx, dave.hansen@xxxxxxxxxxxxxxx, x86@xxxxxxxxxx,	hpa@xxxxxxxxx, acme@xxxxxxxxxx, mark.rutland@xxxxxxx,	alexander.shishkin@xxxxxxxxxxxxxxx, jolsa@xxxxxxxxxx,	namhyung@xxxxxxxxxx, jgross@xxxxxxxx, srivatsa@xxxxxxxxxxxxx,	amakhalov@xxxxxxxxxx, pv-drivers@xxxxxxxxxx,	boris.ostrovsky@xxxxxxxxxx, chris@xxxxxxxxxx, jcmvbkbc@xxxxxxxxx,	rafael@xxxxxxxxxx, lenb@xxxxxxxxxx, pavel@xxxxxx,	gregkh@xxxxxxxxxxxxxxxxxxx, mturquette@xxxxxxxxxxxx,	sboyd@xxxxxxxxxx, daniel.lezcano@xxxxxxxxxx, lpieralisi@xxxxxxxxxx,	sudeep.holla@xxxxxxx, agross@xxxxxxxxxx, bjorn.andersson@xxxxxxxxxx,	anup@xxxxxxxxxxxxxx, thierry.reding@xxxxxxxxx, jonathanh@xxxxxxxxxx,	jacob.jun.pan@xxxxxxxxxxxxxxx, Arnd Bergmann <arnd@xxxxxxxx>,	yury.norov@xxxxxxxxx, andriy.shevchenko@xxxxxxxxxxxxxxx,	linux@xxxxxxxxxxxxxxxxxx, rostedt@xxxxxxxxxxx, pmladek@xxxxxxxx,	senozhatsky@xxxxxxxxxxxx, john.ogness@xxxxxxxxxxxxx,	paulmck@xxxxxxxxxx, frederic@xxxxxxxxxx, quic_neeraju@xxxxxxxxxxx,	josh@xxxxxxxxxxxxxxxx, mathieu.desnoyers@xxxxxxxxxxxx,	jiangshanlai@xxxxxxxxx, joel@xxxxxxxxxxxxxxxxx,	juri.lelli@xxxxxxxxxx, vincent.guittot@xxxxxxxxxx,	dietmar.eggemann@xxxxxxx, bsegall@xxxxxxxxxx, mgorman@xxxxxxx,	bristot@xxxxxxxxxx, vschneid@xxxxxxxxxx, jpoimboe@xxxxxxxxxx,	linux-alpha@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx,	linux-snps-arc@xxxxxxxxxxxxxxxxxxx,	linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-omap@xxxxxxxxxxxxxxx,	linux-csky@xxxxxxxxxxxxxxx, linux-hexagon@xxxxxxxxxxxxxxx,	linux-ia64@xxxxxxxxxxxxxxx, linux-m68k@xxxxxxxxxxxxxxxxxxxx,	linux-mips@xxxxxxxxxxxxxxx, openrisc@xxxxxxxxxxxxxxxxxxxx,	linux-parisc@xxxxxxxxxxxxxxx, linuxppc-dev@xxxxxxxxxxxxxxxx,	linux-riscv@xxxxxxxxxxxxxxxxxxx, linux-s390@xxxxxxxxxxxxxxx,	linux-sh@xxxxxxxxxxxxxxx, sparclinux@xxxxxxxxxxxxxxx,	linux-um@xxxxxxxxxxxxxxxxxxx, linux-perf-users@xxxxxxxxxxxxxxx,	virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx,	xen-devel@xxxxxxxxxxxxxxxxxxxx, linux-xtensa@xxxxxxxxxxxxxxxx,	linux-acpi@xxxxxxxxxxxxxxx, linux-pm@xxxxxxxxxxxxxxx,	linux-clk@xxxxxxxxxxxxxxx, linux-arm-msm@xxxxxxxxxxxxxxx,	linux-tegra@xxxxxxxxxxxxxxx, linux-arch@xxxxxxxxxxxxxxx,	rcu@xxxxxxxxxxxxxxx
 
- Delivery-date: Mon, 13 Jun 2022 12:36:41 +0000
 
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
 
 
 
* Peter Zijlstra <peterz@xxxxxxxxxxxxx> [220608 15:00]:
> On Wed, Jun 08, 2022 at 04:27:57PM +0200, Peter Zijlstra wrote:
> > @@ -254,11 +255,18 @@ void omap_sram_idle(void)
> >      */
> >     if (save_state)
> >             omap34xx_save_context(omap3_arm_context);
> > +
> > +   if (rcuidle)
> > +           cpuidle_rcu_enter();
> > +
> >     if (save_state == 1 || save_state == 3)
> >             cpu_suspend(save_state, omap34xx_do_sram_idle);
> >     else
> >             omap34xx_do_sram_idle(save_state);
> >  
> > +   if (rcuidle)
> > +           rcuidle_rcu_exit();
> 
> *sigh* so much for this having been exposed to the robots for >2 days :/
I tested your git branch of these patches, so:
Reviewed-by: Tony Lindgren <tony@xxxxxxxxxxx>
Tested-by: Tony Lindgren <tony@xxxxxxxxxxx>
 
 
    
     |