[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 4/6] xen: Switch to byteswap
- To: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 23 May 2022 18:14:36 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FpquWPTdkPs4vboyT6efgqWfGQrZ9In3hkbUO+6Myso=; b=I2Wj7P5mXVi/xOWv+wwwAscP4bHJ3NHFRL9luN2MCaIhVTJHmVNN7jtGDkAs6PRVtstlIxuLoZmhoeiainYfSPfLbDSjuScK/8GBXrwwrX35kqrvnYOeCZlcUenj1pkVsqDDmyQxiFooibz5sWDSy3QpXke3G/5TWkzcdwsKZ5+67qeWDD4fjgWvC3pi/tfklZYqcY9VcOplOD4eVqa1iKfX15QZagmCwP2IFu6DjUMKyLjkB1eBlCVivgEym0udBBwodVpn/22wFUBpaDgiQeX084L8TtVn13KLSS6/krAyIsEa25dpS1gLH0qgNDt1eLhNk4ccgfKDVKUXBPSUNQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Vxoi64KltvzFHpLirVPFfpkCmAw6YeAIMP0/F/2q06xeM+vgAV46OaMeDh9RmbD6R2butQZXapt1uOQvdlCbud6CrOAZ24X39OYgiLHICNZ4tZ6+C9utHv/2xK4+9NW9vNqLo18b810csWW3G9J4iSyi+4ll9MZjiBYn3o1WxLCufrZFwxD9wCxLY34J0Xy0XoCXOkn061/1k9bKUv9SsG1ZxSlnAYgxrigZ+MNHRy/reWwVp81d/uxhD+3fUwS7Ea5Y72At1jvnR90D5kZxDSZJ17em7M6fQ55+mkx3/vumjFQRcMGcGvVJw9GWqtTcSOKDKFuRRLgcpDJ/mlueEQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Julien Grall <julien@xxxxxxx>, Lin Liu （刘林） <lin.liu@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 24 May 2022 07:42:19 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 23.05.2022 17:38, Andrew Cooper wrote:
> On 23/05/2022 15:56, Julien Grall wrote:
>> On 23/05/2022 15:50, Lin Liu wrote:
>>> Update to use byteswap to swap bytes
>>> be*_to_cpup(p) is short for be*to_cpu(*p), update to use latter
>>> one explictly
>>
>> But why?
>
> Because deleting code obfuscation constructs *is* the point of the cleanup.
It's obfuscation only as long as not implemented correctly, i.e. dealing
with unaligned data. Then "be*_to_cpup(p) is short for be*to_cpu(*p)" no
longer applies.
Jan
|
