[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] tools/ocaml: Fix stubs the introduction of domain_create.cpupool_id
- To: Edwin Torok <edvin.torok@xxxxxxxxxx>
- From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- Date: Wed, 18 May 2022 10:12:51 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zE2ZrqxLLy74i9pZ8mIIWuhGBGnwzixKs0TeOHb4F24=; b=JgtCgfPJnhf4S06wIvlfVF/6WTsZsK61XeTLraoeX+tivqR7KF6RWWdL2aSoOoFWLRsIGpQWkOWoCn1FYFTeMSOffKbSU9EcOCJzAtKmqFFVk/SzEpQRpd/ebFD/Pp2QDA2wDRhOcCVVD8sxFY9MaCInIcrBcceVRKTfVVJhmWLO+w3lzN6uKazolQ5ij/cLV198Tpqjbprc1ph64ftV1/Bi+9Wva6MJwIhbx2uezMpEseRcf7xuqGMqgi9l48xkG2tSRd1kpP+rzS7ROVuXk55n4/YRe1gVVCEEDUG1ioK5vufE+7s8bqr8rXgPdbbGXLLOVxanO/v755JJFGfJxA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CKgu+hzf+FOmCcJqzkQjJXlw1uht9sg4LLEpg6SQxasATvzfdHxSEXZ15rxtw9TQlTsfYJcTMsIAoZCn0zsxCZf4R/HorPAueprq6036/z9q7I/QwSmSHc17iXVwgYRAmJdvcUchHgbt5LyX5tpkgFT8aKV94yoZiAf/SZNXdynbf97xIlUjy/SXyKDab6c/pEq43d5i/Nb0QgVV4IZ/6V47bLxJAu2bar1egEHpo5kyRv1/XDbI0pw365fvTRB9WkIHT6EojhIawg/YYB+09vCkJ4nSa0/Ywf2SHtXdQ6QF/gWgQirculz5+rxRN50y01UNyrONRGnbn0Sl8FihdA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Christian Lindig <christian.lindig@xxxxxxxxxx>, Luca Fancellu <luca.fancellu@xxxxxxx>
- Delivery-date: Wed, 18 May 2022 10:13:08 +0000
- Ironport-data: A9a23:Q4YCa67gTFz9UY3CkTduAwxRtFDGchMFZxGqfqrLsTDasY5as4F+v mUZXGrTbqnfYzajKY90PY/jp0gFuZHRztdrHAM+qig2Hi5G8cbLO4+Ufxz6V8+wwmwvb67FA +E2MISowBUcFyeEzvuVGuG96yE6j8lkf5KkYAL+EnkZqTRMFWFw0HqPp8Zj2tQy2YXgU1vU0 T/Pi5a31GGNimYc3l08s8pvmDs31BglkGpF1rCWTakjUG72zxH5PrpGTU2CByKQrr1vNvy7X 47+IISRpQs1yfuP5uSNyd4XemVSKlLb0JPnZnB+A8BOiTAazsA+PzpS2FPxpi67hh3Q9+2dx umhurTuUTt5GPDQod42DTlxHD5eGL9H2I/YdC3XXcy7lyUqclPK6tA2VgQaGNZd/ex6R2ZT6 fYfNTYBKAiZgP67y666Te8qgdk/KM7sP8UUvXQIITPxVK56B8ycBfiUo4MFtNszrpkm8fL2T swVczdwKj/HZAVCIAw/A5Mihua4wHL4dlW0rXrK/PZssjSLnWSd1pDOa+XScOSQGP5ng3SK+ 2Pf03X0UgsjYYn3JT2ttyjEavX0tTP2XsceGaO18tZugUaP3SoDBRsOT1y5rPKlzEmkVLp3L 1Ef82wgpK45+UivU/H0RRj+q3mB1iPwQPJVGuw+rQ2Ikazd5l7GAnBeFmIcLts7qMUxWDomk EeTmM/kDiBut7vTTm+B8rCTrnW5Pi19wXI+WBLohDAtu7HLyLzfRDqWJjq/OMZZVuHIJAw=
- Ironport-hdrordr: A9a23:zutUzqORn9xS98BcT5j255DYdb4zR+YMi2TDiHoddfUFSKalfp 6V98jzjSWE8wr4WBkb6LO90DHpewKRyXcH2/hqAV7EZniohILIFvAu0WKG+VHd8kLFh4lgPM tbEpSWTeeAdWSS7vyKrjVQcexQpuVvmZrA7Yix854ud3ASV0gK1XYaNu/vKDwTeOAwP+tdKH Pz3Kp6jgvlXU5SQtWwB3EDUeSGjcbMjojabRkPAANiwBWSjBuzgYSKUySw71M7aXdi0L0i+W /Kn0jS/aO4qcy2zRfayiv684lWot380dFObfb8yfT9aw+cyDpAVr4RH4FqjwpF591HL2xa1u Ukli1QevibLUmhJ11d7yGdgzUImwxelkMKgWXo/UcL5/aJBQ7SQvAx+76wOHHimjUdlcA536 RR022DsZ1LSRvGgSTm/tDNEwpnj0yuvBMZ4KYuZlFkIP0jgYVq3MUiFYJuYeU9NTO/7JpiHP hlDcna6voTeVSGb2rBtm0qxNC3RHw8EhqPX0BH46WuonJrtWE8y1FdyN0Un38G+p54Q55Y5/ 7cOqAtkL1VVMcZYa90Ge9ES8qqDW7GRw7KLQupUB/aPbBCP2iIp4/84b0z6u3vcJsUzIEqkJ CES19cvX5aQTOYNSRP5uw+zvngehTMYd228LAu23FQgMyOeJP7dSueVVspj8ys5/0CH8yzYY fHBK5r
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHYaiYkF2Fwt7YEY0iLRkyR5qKZ760kZYcAgAAF1QA=
- Thread-topic: [PATCH 2/2] tools/ocaml: Fix stubs the introduction of domain_create.cpupool_id
On 18/05/2022 10:51, Edwin Torok wrote:
>> diff --git a/tools/ocaml/libs/xc/xenctrl.ml b/tools/ocaml/libs/xc/xenctrl.ml
>> index 7503031d8f61..8eab6f60eb14 100644
>> --- a/tools/ocaml/libs/xc/xenctrl.ml
>> +++ b/tools/ocaml/libs/xc/xenctrl.ml
>> @@ -85,6 +85,7 @@ type domctl_create_config =
>> max_grant_frames: int;
>> max_maptrack_frames: int;
>> max_grant_version: int;
>> + cpupool_id: int32;
> What are the valid values for a CPU pool id, in particular what value should
> be passed here to get back the behaviour prior to these changes in Xen?
> (i.e. would it be cpu pool id 0 or -1 if cpu pools aren't otherwise
> explicitly configured on the system)
cpupools are a non-optional construct in Xen.
By default, one cpupool exists, with the id 0, using the default
scheduler covering all pCPUs, and dom0 is constructed in this cpupool.
Passing 0 here is the backwards compatible option.
And on that note, Luca, you ought to patch xl/libxl to apply the pool=
setting directly during domain create, rather than depending on cpupool
0 existing and moving the domain later.
~Andrew
|
