[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86/hvm: Widen condition for is_hvm_pv_evtchn_vcpu()
- To: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Jane Malalane <jane.malalane@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 18 May 2022 11:09:29 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=F9Y17SRlcm1fE43VCjzb+soUeKe5kX3r0qi0eDJF/jU=; b=mKdWzqdOxQWORg1K4VD+WS7PyGj5iivuWQGi7B2aQ/M1YYjo/2xeaRuMK5p2lZ9ZAPRygIpbTyr+xBZhXoNrHvgoXrFnMDKnZ7DzNuqrXhsfYMhnN/26UYhaXlY1MJ8pP+Sb+5sfiSzjAXvTh/Q+MRdTdFrNCSlwlAHkEvkyzaioOWSZzRTg1PRVfK/VPPUIFU+7/LfLa9naU4XNuNYY6X/l7STksqvuRqrghh60uO/Kpzk0DPBSMIX3hvq8kDfO6Ed1KO5yy6T2QlBXnNmG6XfcqDiqevGjP3TwHijNFFhCpKNFo/s1Nns6h30g1rddyGS++mupPG5itAFcy5bPoA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ata4159CSmWLSQGEDITJsdZgeVOkT+NfJw5N2LTLyFf9klnwXfT5cAxytCk762cTThWuevKMZmSJM/x3e86rkUx2GTGOj1xW8Z033b0AA55UAI6t+AO5RPwxK2X3eVSGgglzJha5bylDf6PJGNr1PHmaAZsJ0NJqVg6awiP0z9YpIZQZLZqv9mNj51PbYINHX5rx5PnVOOdIREL53vBUqLxcQaPe3JadUb4ai09sXljoRnFrH6vIhWNjay8wYrHADsuAlYgEeaxLwvkkRamBWRQhyhGg3tVmDd3E12hYS4QnsLYt6bU0QwdV7fF7sBuQSUSR/gHABXauaLLfwiGZeA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Wed, 18 May 2022 09:09:39 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 13.05.2022 17:39, Roger Pau Monné wrote:
> On Wed, May 11, 2022 at 04:14:23PM +0100, Jane Malalane wrote:
>> Have is_hvm_pv_evtchn_vcpu() return true for vector callbacks for
>> evtchn delivery set up on a per-vCPU basis via
>> HVMOP_set_evtchn_upcall_vector.
>>
>> is_hvm_pv_evtchn_vcpu() returning true is a condition for setting up
>> physical IRQ to event channel mappings.
>
> I would add something like:
>
> The naming of the CPUID bit is a bit generic about upcall support
> being available. That's done so that the define name doesn't get
> overly long like XEN_HVM_CPUID_UPCALL_VECTOR_SUPPORTS_PIRQ or some
> such.
On top of this at least half a sentence wants saying on why a new
CPUID bit is introduced in the first place. This doesn't derive in
any way from title or description. It would be only then when it
is additionally explained why the name was chosen like this.
Jan
|
