[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86: xen: remove STACK_FRAME_NON_STANDARD from xen_cpuid
- To: Josh Poimboeuf <jpoimboe@xxxxxxxxxx>, Maximilian Heyne <mheyne@xxxxxxxxx>
- From: Juergen Gross <jgross@xxxxxxxx>
- Date: Wed, 18 May 2022 08:51:23 +0200
- Cc: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, Borislav Petkov <bp@xxxxxxxxx>, Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>, x86@xxxxxxxxxx, "H. Peter Anvin" <hpa@xxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
- Delivery-date: Wed, 18 May 2022 06:51:33 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 17.05.22 18:42, Josh Poimboeuf wrote:
On Tue, May 17, 2022 at 04:24:25PM +0000, Maximilian Heyne wrote:
Since commit 4d65adfcd119 ("x86: xen: insn: Decode Xen and KVM
emulate-prefix signature"), objtool is able to correctly parse the
prefixed instruction in xen_cpuid and emit correct orc unwind
information. Hence, marking the function as STACKFRAME_NON_STANDARD is
no longer needed.
This commit is basically a revert of commit 983bb6d254c7 ("x86/xen: Mark
xen_cpuid() stack frame as non-standard").
Signed-off-by: Maximilian Heyne <mheyne@xxxxxxxxx>
CC: Josh Poimboeuf <jpoimboe@xxxxxxxxxx>
cr: https://code.amazon.com/reviews/CR-69645080
^^^^^
This looks like an internal amazon link and should be removed.
Otherwise, looks good to me.
Can be done while committing.
Reviewed-by: Juergen Gross <jgross@xxxxxxxx>
Juergen
Attachment:
OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key
Attachment:
OpenPGP_signature
Description: OpenPGP digital signature
|
