[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86/setup: delay setting SYS_STATE_smp_boot
- To: Roger Pau Monne <roger.pau@xxxxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Mon, 16 May 2022 16:35:51 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wYwSixQBsJZHpMQPn0fIJRbLojA7zqoX+KlqNPLdMAc=; b=cPlqcVRkLlWRnqsInv+eyqW9veegDUiFpLEVH5BGk0OMyfshNsIBeTrOMMx3zNrh1lovv4iaLumv41AVS6KSA78ff3H37kMQTJdoMybpfl4M0nUGGLvHjcXidVW2v0ybJUvydlpnHuuUIFqeTPRJ10xbWYq1+C11ZVOMqDtWJMQ1n5RosZh/yS8u31LrZx6fVeusUA5FwQOrCaBKyY0p3iECfJg3H2f508kHDCA87pX468ls5XpXliyjuwmqWMMG5uPWrnlfKRGrjA8C3Yd5hxlJ1G0ukWkOb/0NsFVrCKV7sjettX12COUKDT59Q+ld9iW4h3u0nxxIEx5nd2uduA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I3dsy33Fp1G96kQyxL68JdnIDyFnvnkg0W7uIieKplZg83x9wtyGs4PK3MqOMzBfPUoIO9W/tVRQHFFU+HSaP34lvqdfWTOn1vU7fwzgtK5XnYhj4AClhoXr06/8JvscrXptw4ChvC5BJPvG2B99b0t/avK+iaPfeRuux3zjpEL8EeciYF6s/CE40399EVrUknTE/LHa/bt+62uPyXnChwmHO/8yPKilUNPerm1xPa2Nczq9plUro3LhNl5bObFxvmw2HKJSQiW+iqazvBXg/1TbsUPW3GpAG57MBHgqIuSfbjvJvuKjpZqQ9N7kDWl/98QRaGrDDV+Wo78OxrqJNQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, Jan Beulich <jbeulich@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Mon, 16 May 2022 14:36:10 +0000
- Ironport-data: A9a23:tKzvF6qUxJwwKNuZinketUPhH1xeBmJsZBIvgKrLsJaIsI4StFCzt garIBnQP67fYGDyKo91ao/n8kJUuZLXy4A3GlA5+So3QywW9puZCYyVIHmrMnLJJKUvbq7GA +byyDXkBJppJpMJjk71atANlVEliefQAOCU5NfsYkidfyc9IMsaoU8lyrdRbrJA24DjWVvQ4 I2q+qUzBXf+s9JKGjNMg068gEsHUMTa4Fv0aXRnOJinFHeH/5UkJMp3yZOZdhMUcaENdgKOf M7RzanRw4/s10xF5uVJMFrMWhZirrb6ZWBig5fNMkSoqkAqSicais7XOBeAAKv+Zvrgc91Zk b1wWZKMpQgBHpDXt+48SgtiNzxYYvZh2qebPHOmiJnGp6HGWyOEL/RGKmgTZNRd0MAnRGZE+ LofNSwHaQ2Fi6Su2rWnR+Jwh8Mlas72IIcYvXImxjbcZRokacmbH+OWupkFjHFp2Z0m8fX2P qL1bRJ1axvNeVtXM0o/A5Mihua4wHL4dlW0rXrK/PZuvTGIl2Sd1pDwasfRfIe3SPlK3WeAt 3Li4GrCCEwzYYn3JT2ttyjEavX0tTP2XsceGaO18tZugUaP3SoDBRsOT1y5rPKlzEmkVLp3K UYZ5y4vpqga71GwQ5/2WBjQiGGAlg4RXZxXCeJS1e2W4q/d4gLcDG5USDdEMYUirJVvGmFs0 UKVldT0AzApqKeSVX+W6raTq3W1JDQRKmgBIyQDSGPp/uXenW36tTqXJv4LLUJ/poad9e3Yq 9xSkBUDug==
- Ironport-hdrordr: A9a23:RmSecq/fpsK+7Yi9quhuk+AoI+orL9Y04lQ7vn2ZKSY5TiX4rb HIoB1/73XJYVkqN03I9ervBEDEewK+yXcX2/h0AV7BZmnbUQKTRekP0WKh+UyDJ8SXzIVgPM xbAs1D4bPLbGSTjazBkXWF+9RL+qj5zEh/792usUuETmtRGtBdBx8SMHf8LqXvLjM2f6bQEv Cnl7N6jgvlQ1s7ROKhCEIIWuDSzue76a4PMXY9dmYaABDlt0LS1ILH
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Mon, May 16, 2022 at 01:12:03PM +0200, Roger Pau Monne wrote:
> Booting with Shadow Stacks leads to the following assert on a debug
> hypervisor:
>
> (XEN) [ 11.625166] Assertion 'local_irq_is_enabled()' failed at
> arch/x86/smp.c:265
> (XEN) [ 11.629410] ----[ Xen-4.17.0-10.24-d x86_64 debug=y Not tainted
> ]----
> (XEN) [ 11.633679] CPU: 0
> (XEN) [ 11.637834] RIP: e008:[<ffff82d040345300>]
> flush_area_mask+0x40/0x13e
> [...]
> (XEN) [ 11.806158] Xen call trace:
> (XEN) [ 11.811255] [<ffff82d040345300>] R flush_area_mask+0x40/0x13e
> (XEN) [ 11.816459] [<ffff82d040338a40>] F modify_xen_mappings+0xc5/0x958
> (XEN) [ 11.821689] [<ffff82d0404474f9>] F
> arch/x86/alternative.c#_alternative_instructions+0xb7/0xb9
> (XEN) [ 11.827053] [<ffff82d0404476cc>] F alternative_branches+0xf/0x12
> (XEN) [ 11.832416] [<ffff82d04044e37d>] F __start_xen+0x1ef4/0x2776
> (XEN) [ 11.837809] [<ffff82d040203344>] F __high_start+0x94/0xa0
>
> Fix this by switching to state SYS_STATE_smp_boot after alternatives
> have been applied.
Consider this patch superseded by:
https://lore.kernel.org/xen-devel/20220516143116.28602-1-roger.pau@xxxxxxxxxx
Thanks, Roger.
|