[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 18/30] notifier: Show function names on notifier routines if DEBUG_NOTIFIERS is set
- To: Xiaoming Ni <nixiaoming@xxxxxxxxxx>
- From: Steven Rostedt <rostedt@xxxxxxxxxxx>
- Date: Tue, 10 May 2022 13:29:22 -0400
- Cc: "Guilherme G. Piccoli" <gpiccoli@xxxxxxxxxx>, <akpm@xxxxxxxxxxxxxxxxxxxx>, <bhe@xxxxxxxxxx>, <pmladek@xxxxxxxx>, <kexec@xxxxxxxxxxxxxxxxxxx>, <linux-kernel@xxxxxxxxxxxxxxx>, <bcm-kernel-feedback-list@xxxxxxxxxxxx>, <coresight@xxxxxxxxxxxxxxxx>, <linuxppc-dev@xxxxxxxxxxxxxxxx>, <linux-alpha@xxxxxxxxxxxxxxx>, <linux-arm-kernel@xxxxxxxxxxxxxxxxxxx>, <linux-edac@xxxxxxxxxxxxxxx>, <linux-hyperv@xxxxxxxxxxxxxxx>, <linux-leds@xxxxxxxxxxxxxxx>, <linux-mips@xxxxxxxxxxxxxxx>, <linux-parisc@xxxxxxxxxxxxxxx>, <linux-pm@xxxxxxxxxxxxxxx>, <linux-remoteproc@xxxxxxxxxxxxxxx>, <linux-s390@xxxxxxxxxxxxxxx>, <linux-tegra@xxxxxxxxxxxxxxx>, <linux-um@xxxxxxxxxxxxxxxxxxx>, <linux-xtensa@xxxxxxxxxxxxxxxx>, <netdev@xxxxxxxxxxxxxxx>, <openipmi-developer@xxxxxxxxxxxxxxxxxxxxx>, <rcu@xxxxxxxxxxxxxxx>, <sparclinux@xxxxxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>, <x86@xxxxxxxxxx>, <kernel-dev@xxxxxxxxxx>, <kernel@xxxxxxxxxxxx>, <halves@xxxxxxxxxxxxx>, <fabiomirmar@xxxxxxxxx>, <alejandro.j.jimenez@xxxxxxxxxx>, <andriy.shevchenko@xxxxxxxxxxxxxxx>, <arnd@xxxxxxxx>, <bp@xxxxxxxxx>, <corbet@xxxxxxx>, <d.hatayama@xxxxxxxxxxxxxx>, <dave.hansen@xxxxxxxxxxxxxxx>, <dyoung@xxxxxxxxxx>, <feng.tang@xxxxxxxxx>, <gregkh@xxxxxxxxxxxxxxxxxxx>, <mikelley@xxxxxxxxxxxxx>, <hidehiro.kawai.ez@xxxxxxxxxxx>, <jgross@xxxxxxxx>, <john.ogness@xxxxxxxxxxxxx>, <keescook@xxxxxxxxxxxx>, <luto@xxxxxxxxxx>, <mhiramat@xxxxxxxxxx>, <mingo@xxxxxxxxxx>, <paulmck@xxxxxxxxxx>, <peterz@xxxxxxxxxxxxx>, <senozhatsky@xxxxxxxxxxxx>, <stern@xxxxxxxxxxxxxxxxxxx>, <tglx@xxxxxxxxxxxxx>, <vgoyal@xxxxxxxxxx>, <vkuznets@xxxxxxxxxx>, <will@xxxxxxxxxx>, Arjan van de Ven <arjan@xxxxxxxxxxxxxxx>, Cong Wang <xiyou.wangcong@xxxxxxxxx>, Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>, Valentin Schneider <valentin.schneider@xxxxxxx>
- Delivery-date: Tue, 10 May 2022 17:29:39 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Thu, 28 Apr 2022 09:01:13 +0800
Xiaoming Ni <nixiaoming@xxxxxxxxxx> wrote:
> > +#ifdef CONFIG_DEBUG_NOTIFIERS
> > + {
> > + char sym_name[KSYM_NAME_LEN];
> > +
> > + pr_info("notifiers: registered %s()\n",
> > + notifier_name(n, sym_name));
> > + }
>
> Duplicate Code.
>
> Is it better to use __func__ and %pS?
>
> pr_info("%s: %pS\n", __func__, n->notifier_call);
>
>
> > +#endif
Also, don't sprinkle #ifdef in C code. Instead:
if (IS_ENABLED(CONFIG_DEBUG_NOTIFIERS))
pr_info("notifers: regsiter %ps()\n",
n->notifer_call);
Or define a print macro at the start of the C file that is a nop if it is
not defined, and use the macro.
-- Steve
|
