[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3] xen/build: Add cppcheck and cppcheck-html make rules

To: Bertrand Marquis <bertrand.marquis@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
From: Julien Grall <julien@xxxxxxx>
Date: Mon, 9 May 2022 19:22:14 +0100
Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>
Delivery-date: Mon, 09 May 2022 18:22:29 +0000
List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

Hi,

On 26/04/2022 13:38, Bertrand Marquis wrote:

diff --git a/xen/arch/arm/include/asm/processor.h 
b/xen/arch/arm/include/asm/processor.h
index 852b5f3c24..ef37cfa16f 100644
--- a/xen/arch/arm/include/asm/processor.h
+++ b/xen/arch/arm/include/asm/processor.h
@@ -219,9 +219,11 @@
                           SCTLR_Axx_ELx_A    | SCTLR_Axx_ELx_C   |\
                           SCTLR_Axx_ELx_WXN  | SCTLR_Axx_ELx_EE)

+#ifndef CPPCHECK


Can you add a comment explaining why you need this check?

With that:

Acked-by: Julien Grall <jgrall@xxxxxxxxxx>

Cheers,

--
Julien Grall

Follow-Ups:
- Re: [PATCH v3] xen/build: Add cppcheck and cppcheck-html make rules
  - From: Bertrand Marquis

Prev by Date: Re: [PATCH v2] arm/its: enable LPIs before mapping the collection table
Next by Date: Re: [PATCH v2] xen/arm: p2m don't fall over on FEAT_LPA enabled hw
Previous by thread: [ovmf test] 170274: regressions - FAIL
Next by thread: Re: [PATCH v3] xen/build: Add cppcheck and cppcheck-html make rules
Index(es):
- Date
- Thread

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.