Re: [PATCH v8 0/7] Boot time cpupools

[Julien Grall <julien@xxxxxxx>]

Hi Luca,

On 06/05/2022 12:25, Luca Fancellu wrote:
> > The example DT is instructing Xen to have two cpu pools, one having two phisical
> > cpus and the one having 4 phisical cpus, the last mentioned cpu pool uses the
> > null scheduler and from the /chosen node we can see that a dom0less guest will
> > be started on that cpu pool.
> >
> > In this particular case Xen must boot with different type of cpus, so the
> > boot argument hmp_unsafe must be enabled.
> >
> > Luca Fancellu (7):
> >   tools/cpupools: Give a name to unnamed cpupools
> >   xen/sched: create public function for cpupools creation
> >   xen/sched: retrieve scheduler id by name
> >   xen/cpupool: Create different cpupools at boot time
> >   xen/cpupool: Don't allow removing cpu0 from cpupool0
> >   arm/dom0less: assign dom0less guests to cpupools
> >   xen/cpupool: Allow cpupool0 to use different scheduler
> >
> > MAINTAINERS                            |   2 +-
> > docs/misc/arm/device-tree/booting.txt  |   5 +
> > docs/misc/arm/device-tree/cpupools.txt | 140 +++++++++++++++
> > tools/helpers/xen-init-dom0.c          |  37 +++-
> > tools/libs/light/libxl_utils.c         |   3 +-
> > xen/arch/arm/domain_build.c            |  19 +-
> > xen/arch/arm/include/asm/smp.h         |   3 +
> > xen/common/domain.c                    |   2 +-
> > xen/common/sched/Kconfig               |   7 +
> > xen/common/sched/Makefile              |   1 +
> > xen/common/sched/boot-cpupool.c        | 234 +++++++++++++++++++++++++
> > xen/common/sched/core.c                |  40 +++--
> > xen/common/sched/cpupool.c             |  43 ++++-
> > xen/include/public/domctl.h            |   5 +-
> > xen/include/xen/sched.h                |  53 ++++++
> > 15 files changed, 563 insertions(+), 31 deletions(-)
> > create mode 100644 docs/misc/arm/device-tree/cpupools.txt
> > create mode 100644 xen/common/sched/boot-cpupool.c
> >
> > --
> > 2.17.1
> Ping?
You seemed to have forgotten to CC the relevant maintainers on each 
patch and the cover letter. I only got this e-mail because I have a 
filter for some keywords.
> The v8 seems to be reviewed for all patch
>
> https://patchwork.kernel.org/project/xen-devel/list/?series=634064
AFAICT, patchwork only tells you the number of reviewed-by tag. It 
doesn't tell you whether the patch was suitably reviewed.
Looking through the patches:
  #1: Ready
  #2: Ready
  #3: Ready
  #4: Missing review from the cpupool maintainers (Juergen or Dario)
  #5: Ready
  #6: Missing review from the cpupool maintainers
  #7: Ready

Cheers,

--
Julien Grall