Re: [PATCH 1/2] xen/arm: gnttab: use static inlines for gnttab_{release_}host_mapping*

[Michal Orzel <michal.orzel@xxxxxxx>]

On 05.05.2022 13:13, Jan Beulich wrote:
> On 05.05.2022 12:36, Michal Orzel wrote:
>> --- a/xen/arch/arm/include/asm/grant_table.h
>> +++ b/xen/arch/arm/include/asm/grant_table.h
>> @@ -29,12 +29,21 @@ static inline void gnttab_mark_dirty(struct domain *d, 
>> mfn_t mfn)
>>  #endif
>>  }
>>  
>> +static inline bool gnttab_host_mapping_get_page_type(bool ro, struct domain 
>> *ld,
>> +                                                     struct domain *rd)
>> +{
>> +    return false;
>> +}
>> +
>> +static inline bool gnttab_release_host_mappings(struct domain *d)
>> +{
>> +    return true;
>> +}
> 
> Looking at x86 I think all three instances of struct domain * want to
> be const struct domain *. Then
> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
> 
> Jan
> 
Thanks. I think we should mark all parameters as const meaning also const bool 
ro.

Cheers,
Michal