[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: fix and cleanup discard_alignment handling
- To: Christoph Hellwig <hch@xxxxxx>
- From: "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>
- Date: Tue, 26 Apr 2022 00:16:21 -0400
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VgShOSuxQqfoj97gAL6GK2pWBCOuBmWMfHpOmNYmLms=; b=MELrS1W3JzftJQi7nfd3yt907GKzrEuF69GOSkRcSt/yRF0P26S8bQJ3u5SkwIh0cbPh/4ivs7IazWwxNEzZuDmdrvufbsv1y9r2NtHzoWo80/GIyAOCopQpRS3vQYoRIo4eGWfsudOh0C6qucCJFG21qOmmTOxEKGvrOsUO+etVxSrAc947LtMJM6bXqTIh5nhnlWjxNB0GOtSQ6vZTzyBo+HadFY+E5bfv6pIpzk5wldicLOXEXu+ZRKS1179vvO1XHRQsi8So10WAuPLIms6ajGHbjwXkzrTBwQxPBvDCMrIfTM0degoP/A7PqMTdRDHZbTcDPtXzs1+/+qwQGw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZUOhLZKNL3vrNl/maSq9xt45/b5a9NdXwIhXvstJAYwIsAi0DxupEQl/Yvix7bJkhWOcyWDMj1Z86LqzR2sBaF9Njm7mKI0E7iPfS6tvhupy6YoXis7wjl2yAmEg3XVwIwnRD7TXGS7Lp4uSKHm+D+vNIIKsp07IgnqK3C/esfCnpvAQspS/rwxCLYikKu3NATPpsD8FIckfWAfsADoxVsInmB+mfKQ5CeQKCpwTgVdzibDwYWjb0/FhMPRYu+CM7azS0uotfZMZj4EMLuozZJHZhuyydbp/FNVzkBbrTHENZwrGfiMYt1NkVjqWTGu+IUDuJEm5vrAdkdX6U4bYvg==
- Cc: Jens Axboe <axboe@xxxxxxxxx>, Richard Weinberger <richard@xxxxxx>, Johannes Berg <johannes@xxxxxxxxxxxxxxxx>, Josef Bacik <josef@xxxxxxxxxxxxxx>, "Md. Haris Iqbal" <haris.iqbal@xxxxxxxxx>, Jack Wang <jinpu.wang@xxxxxxxxx>, "Michael S. Tsirkin" <mst@xxxxxxxxxx>, Jason Wang <jasowang@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Mike Snitzer <snitzer@xxxxxxxxxx>, Song Liu <song@xxxxxxxxxx>, Stefan Haberland <sth@xxxxxxxxxxxxx>, Jan Hoeppner <hoeppner@xxxxxxxxxxxxx>, "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>, linux-um@xxxxxxxxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, nbd@xxxxxxxxxxxxxxxx, virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, linux-raid@xxxxxxxxxxxxxxx, linux-nvme@xxxxxxxxxxxxxxxxxxx, linux-s390@xxxxxxxxxxxxxxx, dm-devel@xxxxxxxxxx
- Delivery-date: Tue, 26 Apr 2022 04:16:58 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Christoph,
> the somewhat confusing name of the discard_alignment queue limit, that
> really is an offset for the discard granularity mislead a lot of
> driver authors to set it to an incorrect value. This series tries to
> fix up all these cases.
Not sure how I ended up with "discard_alignment" when I called the
corresponding I/O parameter "alignment_offset".
Anyway. All this looks good to me.
Reviewed-by: Martin K. Petersen <martin.petersen@xxxxxxxxxx>
--
Martin K. Petersen Oracle Linux Engineering
|
