[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1.1 2/3] x86/build: Don't convert boot/{cmdline,head}.bin back to .S
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- Date: Wed, 20 Apr 2022 12:47:18 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NkeRCNNE6NO3vqwczH4AqDoKgpWiY9CwvYfF8dQKHvw=; b=G0uQ53vZ4EvsX9pgv/Ub5oun0rM2Je3nfRmF4AbMxXDs9wG5FqZDY083kILWK3YvYT+LftSNPfUPMRRXbmLbpN2DHOy3EQoekoM4ba19EqpY2mlhpR/djPT+JJLKxkAAju5/iFzhXPFeGDyj6ZDQLdCHXsssTnns2H4ifxHjs8m/MaYWNmD2zQIXfBEE5qGUx26zuUO420yY8JnUREVS6SrWF2CfyKuuWM7pasXf6KIJnGbs48cgxi1OxYr7bqNToDtMOU+NxBYNbsQTDH4aslev0vmM3fJG51oLWFEmppDV0BfkPddrMZd1Z5JtDYzOq5EXTFbHN6USl0e8sD+OcQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oUVqb7/vjgJ/Bf4NdgWUoa35LQjncTWH3JNgfbPGJ1aaEj96jLQ7EaMQMDu+EOGChOxQM989rSGUKHzTC2yPAgXBqPlGxoZVpzsq96MWWDUkfi3Sck0URMGxte1sSivLYVRu9LrH1r8l0pJ8+1M2JsAMCKCN853/P1FfltGNyRhppaKwhivK/MebcfScuJxiynHmBXm9GUyiuCZL0b9xscWjb78Z1g6ZfBCE9w/XCavfuqi8HuC1JoBgGc8GfYvl8iTBhA6zocO513+gJg1lUUUzejeRAguUAwk00yVA1I0zYZe+tcizexcvuPjx/bOCgxX5XS6R6GxBJJAc5UYifQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Roger Pau Monne <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 20 Apr 2022 12:47:43 +0000
- Ironport-data: A9a23:xMaRbKP8yJrhfO3vrR3WlsFynXyQoLVcMsEvi/4bfWQNrUom32dUn 2scCGyFOKzeYWGhKdwnOd/kpEoFvpDcydVnGwto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FFcMpBsJ00o5wbZl2NYw2LBVPivW0 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z6 Olhnp33QyYSPobqtPoldQNeTSEnFPgTkFPHCSDXXc276WTjKiOp79AwSUY8MMsf5/p9BnxI+ boAMjcRYxufhuWwhrWmVu1rgcdlJ87uVG8dkig4kXeFUrB7EdaaG/iiCdxwhV/cguhnG/rEa tVfQj1odBnaODVEO0sNCYJ4l+Ct7pX6W2MJ9QrK+vtoi4TV5CpPjbHkEfWLQJutV+EPrhedg nnfoHusV3n2M/Tak1Jp6EmEhOXCgCf6U4I6D6Cj+7hhh1j77nMXIA0bUx28u/bRol6zXZdTJ lIZ/gIqrLMu7wq7Q9/lRRq6rXWY+BkGVLJt//YS7QiMzu/Y5lifD21dFjpZMoV+6YkxWCAg0 UKPk5XxHztzvbaJSHWbsLCJsTe1PitTJmgHDcMZcTY4DxDYiNlbpnryohxLSsZZUvWd9enM/ g23
- Ironport-hdrordr: A9a23:LWy0FK7Lf2VcY3EOIAPXwZGCI+orL9Y04lQ7vn2ZFiY5TiXIra qTdaogviMc0AxhI03Jmbi7Scq9qeu1z+843WBjB8bZYOCAghrmEGgC1/qu/9SEIUHDH4FmpM BdmsRFaeEYSGIK9foSgzPIXerIouP3lpxA7N22pxgCcegpUdAY0+4TMHf4LqQCfngjOXNPLu v42iMonVqdUEVSSv7+KmgOXuDFqdGOvonhewQ6Cxku7xTLpS+06ZbheiLonis2Yndq+/MP4G LFmwv26uGIqPeg0CLR0GfV8tB/hMbh8N1eH8aB4/JlaQkEyzzYJriJaYfy+Azdk9vfr2rCV+ O85SvICv4Drk85uFvF+CcFlTOQiArGoEWStGNwyUGT3fARAghKSvapzLgpDCcwoSAbza5B+b MO0GSDu5VNCxTc2Cz7+tjTThlv0lG5uHw4jIco/jRiuKYlGclsRLYkjQpo+VY7bVDHwZFiFP MrANDX5f5Qf1/fZ3fFvnN3yNjpWngoBB+JTkULp8TQilFt7TpE5lpdwNZakmYL9Zo7RZUB7+ PYMr5wnLULSsMNd6pyCOoIXMPyAG3QRhDHNn6UPD3cZeo6EmOIr4Sy7KQ+5emsdpBNxJwumI 7ZWFcdrmI2c1KGM7z44HSKyGG4fIyQZ0Wc9igF3ekJhlTVfsuZDQSTDFYzjsCnv/ITRsXGRv fbAuMiP8Pe
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHYUBya0e9ha5i+akWuF9Hg8XHktKz4v0CAgAAKD4A=
- Thread-topic: [PATCH v1.1 2/3] x86/build: Don't convert boot/{cmdline,head}.bin back to .S
On 20/04/2022 13:11, Jan Beulich wrote:
> On 14.04.2022 18:27, Andrew Cooper wrote:
>> There's no point wasting time converting binaries back to asm source. Just
>> use .incbin directly. Explain in head.S what these binaries are.
> Hmm, yes. Why in the world did we do this all these years?
One of many good questions. Others include "why the gratuitous
subsell?" and "who's teaching that 'od | tr | awk | sed | sed | sed' is
a clever idea?" Apparently someone was under the impression that forks
and userspace pipes were free...
>> Also, align the blobs. While there's very little static data in the blobs,
>> they should have at least 4 byte alignment. There was previously no
>> guarantee
>> that cmdline_parse_early was aligned, and there is no longer an implicit
>> 4-byte alignment between cmdline_parse_early and reloc caused by the use of
>> .long.
> There's no alignment associated with using .long, so I think you
> want to re-word this.
What I mean is that .long will guarantee to have a 4 byte size, so reloc
used to end up with the same alignment that cmdline_parse_early did (as
far as internal static data is concerned), whereas now it doesn't.
~Andrew
|
