[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 06/10] xen: introduce an arch helper for default dma zone status


  • To: Wei Chen <wei.chen@xxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Tue, 19 Apr 2022 11:18:43 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9/eKHA1VPKRbfAN23U1roDzl2rc0BI/5cpXLR7sEMkQ=; b=SX2wGUIyTs0nTcQTTSLW9De3zSZfjgUPlXuD2XF+fMTm0AtjtA3FC3McFyjPIQ79A3YtHv0eyJjyXjajVQ35oPtX/kclT5We2fp8l7OpYbsI90Wamd/vtdMi5XBtd7u5LzDpBZj/9IENMf79epGMDKtH4XxgKDhBrXh5tRneWRvkyWs0O1vtKbEZeHGglBdi4bThPd4sGTGgDjK2d8WI2Gvuf0d+gfEIRUjmg1lmpQnoawAIKmmCAfJ4CMHEQwUdO5+dO1YVGrcfLEyECETxeazywlhyrLJ+E+I0u+G7gllTgYopn+0Oj4V5GRfSjGHrF3ehxjtq4BaM+nGdTuKbkg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bMX4NSzUrTv4AS9k0NUga5wrzsI7iCJRWlw9EsHv+7SDIBCwd2FqwpeQy/OwczFrCMa9NHvch1nPkwA1vztF47a4+ceNvF4JLiPLlsmHPPRRdIoINcPPRqr9In5NXx8YNr4NHuBTj6KCEQ7nsIi5EpXWQ5R4nHMYlxRGj0mm49Tx8q6tt1qDbX9Lq6365RNNZiYSxowr/8XeZd0sgALhqNMk+fUPIwqzO7MhSxCXdsyMKumXi71oZTuCF6CmpxqO3HlPI2P/3jdSehY0FbpNjlI8oS4q6Mj21MHmM5HxT+9MJ0NiubfLqJV8tWgmZpY5A065xJsHRTXlp38zIb9xLw==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: nd@xxxxxxx, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Tue, 19 Apr 2022 09:18:53 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 18.04.2022 11:07, Wei Chen wrote:
> --- a/xen/common/page_alloc.c
> +++ b/xen/common/page_alloc.c
> @@ -1889,7 +1889,7 @@ void __init end_boot_allocator(void)
>      }
>      nr_bootmem_regions = 0;
>  
> -    if ( !dma_bitsize && (num_online_nodes() > 1) )
> +    if ( !dma_bitsize && arch_have_default_dmazone() )
>          dma_bitsize = arch_get_dma_bitsize();

Considering its purpose, may I suggest "want" instead of "have" in the
hook name?

Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.