Re: [PATCH v7 4/7] xen/cpupool: Create different cpupools at boot time

[Stefano Stabellini <sstabellini@xxxxxxxxxx>]

On Tue, 12 Apr 2022, Jan Beulich wrote:
> On 12.04.2022 11:50, Luca Fancellu wrote:
> >>> ---
> >>> MAINTAINERS | 2 +-
> >>> docs/misc/arm/device-tree/cpupools.txt | 140 +++++++++++++++++
> >>> xen/arch/arm/domain_build.c | 5 +-
> >>> xen/arch/arm/include/asm/smp.h | 3 +
> >>> xen/common/Kconfig | 7 +
> >>
> >> For consistency, should the addition here - with ...
> >>
> >>> xen/common/sched/Makefile | 1 +
> >>> xen/common/sched/boot-cpupool.c | 207 +++++++++++++++++++++++++
> >>> xen/common/sched/cpupool.c | 12 +-
> >>
> >> ... the new file now under sched/, also be put in sched/Kconfig?
> > 
> > Hi Jan,
> > 
> > I was looking for this change, I see xen/common/Kconfig offers the menu 
> > “Common Features”
> > and the xen/common/sched/Kconfig offers the “Scheduler” menu (visible with 
> > EXPERT), so
> > I thought it was better to leave it in “Common Features”.
> > 
> > Are you suggesting another menu under “Common Features”? 
> 
> No, I'm not suggesting a new menu. I was merely wondering whether the
> Kconfig contents wouldn't location-wise better match where the
> respective source file lives.

It could be in xen/common/sched/Kconfig at the beginning of the file
before creating the new "Schedulers" menu, e.g.:

diff --git a/xen/common/sched/Kconfig b/xen/common/sched/Kconfig
index 3d9f9214b8..f6545f4e9b 100644
--- a/xen/common/sched/Kconfig
+++ b/xen/common/sched/Kconfig
@@ -1,3 +1,10 @@
+config BOOT_TIME_CPUPOOLS
+       bool "Create cpupools at boot time"
+       depends on HAS_DEVICE_TREE
+       help
+         Creates cpupools during boot time and assigns cpus to them. Cpupools
+         options can be specified in the device tree.
+
 menu "Schedulers"
        visible if EXPERT
 

I think it is fine either way, so:

Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>