[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] x86/irq: Skip unmap_domain_pirq XSM during destruction


  • To: Jason Andryuk <jandryuk@xxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Fri, 8 Apr 2022 12:37:09 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+L8XbTYH5iN0XL/FNUMIrcVAFDUQX1nzM7sUDNTxEH0=; b=M8WczUwKp2u5uwuradTn6RoY+bJQxbONji8qdQR0QMtwglCJYeKlIKr2e0PCn4rbnyQ8/quH5/uQQMjdIN94xheSlyh61+gWqzoor6M7O9onncdMLQQ++F1e72zxDSJSZ7EzIIHCbXoC5deRUB1afbW4HM7QDxZDppuJNSPtpapD1wQ3eUgaXJZ8jWvOP1PxQShcLcVQxpoxevTsKnoQgtHQKNcdDyAKsk5tFUJJECwu1KnssgFksnRHKd3Ha/5Ol6G6dVeYQRSS1RUyDN6Ik/kQJxU64AqwUiGuZnXf4FEmRUVNZCyiQ0p9xsxZmz0lvZI/TaiCS9KBTj2T3cpNBg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gYA7Z9T9iuyNQfBkPMM2Vsfzpl+IwscV5WUkuhPXvirrqcLo2kmgd76HS+Y8bpN3HpYRcZwRgvXIhcX2yQ0Qq3rNNbdW9RIFuwHv0eblxdZOPPQKCqK06NIM0dnsGrvVu1Fu+gDyRzSjDWRQQOTyzzVvLwiw3mlxA8PaoMyejReO9FZya1b1UFWl0HIp6nahZG9mlXILA/hUfr2TW/Iv/9EpLKZ6mA9pfKxh+abbmwFP7HPhKmTR7uhpbFoG0KOKYqa1gvxy4wIE2HsUrUX1NiC2kzvTcARtJsbn9lAgUbQyhwqMyTdi0UmbvYZ2Vn7Asn+cgushVh7q9EiPQBX1yg==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Fri, 08 Apr 2022 10:37:23 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 07.04.2022 16:51, Jason Andryuk wrote:
> xsm_unmap_domain_irq was seen denying unmap_domain_pirq when called from
> complete_domain_destroy as an RCU callback.  The source context was an
> unexpected, random domain.  Since this is a xen-internal operation,
> going through the XSM hook is inapproriate.
> 
> Check d->is_dying and skip the XSM hook when set since this is a cleanup
> operation for a domain being destroyed.
> 
> Suggested-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> Signed-off-by: Jason Andryuk <jandryuk@xxxxxxxxx>

Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.