[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 4/9] xen: export evtchn_alloc_unbound
- To: Stefano Stabellini <sstabellini@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 5 Apr 2022 11:50:08 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/qp2ByoPAY/8DAZJpeNEOCm7civFrFP5567MBR9L+nA=; b=e4a4vKMyS0YR0mTq36OUGYA2pPJwOb9LdstworxbSt3PF6J7pJ5n/w/PzPq+9hB7ss9WI6cbY4GkXinzP5ZO5Z4PT7FVSVdqH1vjhgXX48Du5d6tLKSyhwYkTXV1FPtRnulkN5GfRa6u5Ao34Ury8FB74RxWNxrtFRxTWRzjuSYV822Vc7Cbi92eJs2fdt+1QwynM0T5wBBLLRxBmZzzj0InlDDHsqSeOgzFRZ/YSoN8yLp7aitIX+nwk3HjnJLB0F2W1n/G8lIf5sJ4eNkGC+215qqBDDUy6GKiZEznfLT4ZElW3Aa2v6q056abmkVrh+puqZaiJqj/Ua/zv6Moog==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eJXHzDVCtQkWETSRyqVo6fskQV7PL9XSM7etYWxkYAu3jd/jlfP2d1nvwvSpJKhRuAYeh4sor3led8OuT2bPJw+mt47mGmNwt3ziIuS1cDEJBlKKNrPL692yog3vKW1fOPBheitbnyJemtElKxnVVWOGU65xl/hI6G2T858G5xRUwzLXYlgItYw+AvAhC4vyCNESwv4otmJIcKX3Xh7fiVoMKjt83wJYB6d9PcwKzOovWxd1SLJpFI8cU9Y9Ua788sids6mP6/kw2TZAJk3npPadKSgW5jNnaBX7hDGBkkaCt0lg6iALIF5i4iwqhv+PiR9of/ITdQvRibR4v1NKsw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: jgross@xxxxxxxx, Bertrand.Marquis@xxxxxxx, julien@xxxxxxx, Volodymyr_Babchuk@xxxxxxxx, Stefano Stabellini <stefano.stabellini@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 05 Apr 2022 09:50:37 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 01.04.2022 02:38, Stefano Stabellini wrote:
> From: Stefano Stabellini <stefano.stabellini@xxxxxxxxxx>
>
> It will be used during dom0less domains construction.
>
> Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxx>
I think this better wouldn't be a patch of its own. Functions should
be non-static only when they have a user outside of their defining TU.
> --- a/xen/include/xen/event.h
> +++ b/xen/include/xen/event.h
> @@ -71,6 +71,9 @@ void evtchn_free(struct domain *d, struct evtchn *chn);
> /* Allocate a specific event channel port. */
> int evtchn_allocate_port(struct domain *d, unsigned int port);
>
> +/* Allocate a new event channel */
> +int evtchn_alloc_unbound(evtchn_alloc_unbound_t *alloc);
I wonder whether while exposing it the function should also become
__must_check.
Jan
|
