[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 03/10] xen: harmonize return types of hypercall handlers
- To: Juergen Gross <jgross@xxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 24 Mar 2022 14:57:11 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iZQweW+I+pgt+FcfWnbZaBe6HbyN6BVC7Jlb0Seu79k=; b=Uodsl6vFC39b39q4WZSCVg9GUEwBNFD83hhkHHxZGm2xrHNX55ArBC5nobisnRquGd6cXJIhU3F3tOFyQ1lY2puXGtP7Mo814XcaaSNnrOIaK0j/g7jDIzW55gpQQlR+Ta2LwSq3nHJ0I7T2mbWuipxa+PtHONtJneBsSKcEQTj0ARdkfllHK7MuZAONERSlP2oD6XQhxSjz5p7woELxjqLVQXr2zWxpypfK8MW5Nfkj6n4SXXOSOnpTKXdxdnUVAxFq+fHpjNJf81Xb/vl/PcISezWpgLVbX7+tyhoIF47/C+Egf/SyoEATNsvjOFN0GpwBilhkLd7FOGYlAPXBKQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I9aRfU5ijh59Rxjuv7w/Evt06sxCV1GLSp6cKHQXJ9PmMW3lsRTJXH7kGsHqRSz1vlW/7Bw1lFOMitTgl7khHOpnT+hUBjARQMxVGZ6UpDT0ISgxFdqec9Ys6A/IW4MSN2eHUqjB4xJ3CaCt1WOdstT4/wo8N+SvWWQczDcWwDfwdZ9UdrF0EgFyEA0alPQVGjMHL7r8JdVqpNiqO6nflt4ozJJFsJnyMcmc6ZgfW0QbeMyw61+k0eoMh8fqKZVo11vHMSLXwaqFpUVcy9xOFuL8L+27/SwNWhqJgFRzpkwPQ5jft/+7iZ6QAVFa3Zz2trMbSh/5kX2XRkvU8oucqw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Christopher Clark <christopher.w.clark@xxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Thu, 24 Mar 2022 13:57:22 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 24.03.2022 12:19, Juergen Gross wrote:
> On 24.03.22 11:57, Jan Beulich wrote:
>> On 24.03.2022 09:13, Juergen Gross wrote:
>>> Today most hypercall handlers have a return type of long, while the
>>> --- a/xen/arch/x86/x86_64/platform_hypercall.c
>>> +++ b/xen/arch/x86/x86_64/platform_hypercall.c
>>> @@ -4,6 +4,7 @@
>>>
>>> EMIT_FILE;
>>>
>>> +#include <xen/hypercall.h>
>>> #include <xen/lib.h>
>>> #include <compat/platform.h>
>>> #include <xen/hypercall.h>
>
> This seems to be an artifact of the rebase done in V4 of the series, which
> was necessary as Andrew's large series used two patches of my V3 series.
>
> Do you want me to resend without this hunk?
Well, I'd also be fine if you tell me the proper resolution of the
issue in the next patch. I guess the hunk there than also needs
dropping? And patch 5 adjusting accordingly for context? Overall
it may indeed be better if you resent ...
Jan
|
