[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] CI: Don't run Coverity on forks
- To: Roger Pau Monne <roger.pau@xxxxxxxxxx>
- From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- Date: Wed, 23 Mar 2022 11:19:50 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=A+pvQvl/u1V7KFqoDn1xIwi6dQmf93EtZuy4aB8o3kE=; b=dC1/BOuHAZNaU4MYHa/Ps/y3fyP6gfAksbdcAiDRKiBDGXMYzd+QJaKNFGrvILg1z9uwnWxsE1kfkN0Nk1SKMQB7sLY40ujsq9i17KCJe6nF7SDTLeN63DZ45jIx3fgzC7AECPYWaxRw3VrbeXDU39MItR0cDuN47KF1/JnA9AcofQXDDMzu/lGYFQOcLXUtqJAEGryDeAh7gUbnf2UyRzZQteK5t4HY4GE/k67ukHx27cETv0UmvWOO28yvIHpqNZFTwBRfiTyDskQ8huXmxSB0jejQJUEF7C06QLmVdOta12NHc2lXg0wZ8kQFqv7V/OVYOKz9YT83OytHIY6Jhg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FCKYLMBP6NibLX89BIO+mj+rWhMClrHDtmtmQGH+ZjAAxeLiMASoThC/uIbGfos1ZnEJZRIDD7iEKnEyOBmlcykEgzyMiiKQgtNwt3YKjWJr2PsKDCplVWGeAW4xzFNsOnd+y7Wpd0+eKc5Ir3ZvbJOfqABkR871ig+Nob5zufVzrNSJZ8alYeN8HOX9hJcfVbRlrGr0zyOqDnOPW0X1fhpdX1OsvLLEd3YsgaiRRieq7FPAfvX5HaB1rjqAWfRRAz0LWR7ojiQ3ij6UA+Qm1CS+vkrhBt6RoBq/LvBK8EnHSGAqaU1xgKYHrRoSbpjlfowMegcKsBL1LgyR9oCQFg==
- Authentication-results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxx>, "Stefano Stabellini" <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Julien Grall <julien@xxxxxxx>
- Delivery-date: Wed, 23 Mar 2022 11:20:09 +0000
- Ironport-data: A9a23:9idita8jEcEaYHhd0eABDrUDun6TJUtcMsCJ2f8bNWPcYEJGY0x3z 2VNXDqEOv7ba2qmet8kYNvj/E0P7MfXm9M3SQo/ri08E34SpcT7XtnIdU2Y0wF+jyHgoOCLy +1EN7Es+ehtFie0Si+Fa+Sn9T8mvU2xbuKU5NTsY0idfic5DnZ54f5fs7Rh2NQw2oLiW1rlV e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9 DlCnYHoahh1P/L1o+UAaTsINBt0BZVbyrCSdBBTseTLp6HHW37lwvEoB0AqJ4wIvO1wBAmi9 9RBdmpLNErawbvrnvTrEYGAhex6RCXvFKoZtmtt0nfyCvE+TIqYa67L+cVZzHE7gcUm8fP2O ZtCM2c3NEWojxtnHGVNOokjzMWUiWTdTBMH8U2sgrAa2j2GpOB2+Oe0a4eEEjCQfu1Kmm6Iq 2SA+H72ajkYKdiexDyt4n+qwOjVkkvTQ5kOHbe18vprhly7xWEJDhASE1yhrpGRmkO4Ht5SN UEQ0i4vtrQpslymSMHnWB+1q2LCuQQTM/JyOeAn7ACGyoLP/h2UQGMDS1Z8hMcO7ZFsA2Zwj xnQwo2vVWcHXKCppWy16++3sm+zZhEuLHI4R38jdwE928TRr9Rm5v7QdepLHKmwh9zzPDj/x TGWsSQz74kuYd43O7aTpg6e3W/1znTdZktsv1iMADr5hu9sTNT9D7FE/2Q3+hqpwGyxalCa9 EYJlMGFhAzlJcHczXfdKAnh8VzA2hpkDNE+qQM3d3XC3270k5JGQWy2yGgvTKuOGpxYEQIFm GeJ5WtsCGZ7ZRNGl5NfbYOrENgNxqP9D9njXf28RoMQPscgK1TWrHwyPhH4M4XRfK4Ey/xX1 XCzK5vEMJrnIf4/kGreqxk1j9fHORzSNUuMHMumnnxLIJKVZWKPSKdtDbd9RrtR0U9wmy2Mq 4w3H5LTk313CbSiCgGKod97BQ1bdhATWMGpw/G7g8bee2KK7kl6UKSPqV7gEqQ495loehDgp SjsBBUHlAKh2RUq62yiMxheVV8mZr4mxVoTNi0wJ1e4nX8lZIek9qAEcJUrO7Ig8YReITRcF JHpp+3o7ixzdwn6
- Ironport-hdrordr: A9a23:pc78RK1FH3/XDVBUmNwMOAqjBLwkLtp133Aq2lEZdPU1SKClfq WV98jzuiWatN98Yh8dcLK7WJVoMEm8yXcd2+B4V9qftWLdyQiVxe9ZnO7f6gylNyri9vNMkY dMGpIObOEY1GIK7/rH3A==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHYPSvcWrGNYMcnAkWJCvNqV4tZeqzJ76qAgALlz4A=
- Thread-topic: [PATCH] CI: Don't run Coverity on forks
On 21/03/2022 15:04, Roger Pau Monné wrote:
> On Mon, Mar 21, 2022 at 01:58:28PM +0000, Andrew Cooper wrote:
>> By default, workflows run in all forks, but the Coverity token is specific to
>> us, causing all other runs to fail.
>>
>> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Acked-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
>
> Albeit I have a suggestion to make this more useful I think
>
>> ---
>> CC: Roger Pau Monné <roger.pau@xxxxxxxxxx>
>> CC: George Dunlap <George.Dunlap@xxxxxxxxxxxxx>
>> CC: Jan Beulich <JBeulich@xxxxxxxx>
>> CC: Stefano Stabellini <sstabellini@xxxxxxxxxx>
>> CC: Wei Liu <wl@xxxxxxx>
>> CC: Julien Grall <julien@xxxxxxx>
>> ---
>> .github/workflows/coverity.yml | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/.github/workflows/coverity.yml b/.github/workflows/coverity.yml
>> index 427fb86f947f..f613f9ed3652 100644
>> --- a/.github/workflows/coverity.yml
>> +++ b/.github/workflows/coverity.yml
>> @@ -8,6 +8,7 @@ on:
>>
>> jobs:
>> coverity:
>> + if: github.repository_owner == 'xen-project'
> Since I don't know anything else similar, why not make this a secret,
> ie: ${{ secrets.RUN_COVERITY_SCAN }}? So that people could decide to
> enable coverity on their own repos if desired.
>
> We would also need to introduce a ${{ secrets.COVERITY_SCAN_PROJECT }}
>
> To allow setting a different project name.
We wouldn't need a secret here. We could do it on on the existence of
the PROJECT field.
But if we're doing this, then we also need to make the branch selectable
too via the same mechanism.
~Andrew
|
