Re: [PATCH 1/1] xen/blkfront: fix comment for need_copy

[Juergen Gross <jgross@xxxxxxxx>]

On 21.03.22 11:05, Roger Pau Monné wrote:
> On Thu, Mar 17, 2022 at 03:09:30PM -0700, Dongli Zhang wrote:
> > The 'need_copy' is set when rq_data_dir(req) returns WRITE, in order to
> > copy the written data to persistent page.
> >
> > ".need_copy = rq_data_dir(req) && info->feature_persistent,"
> I would also add:
>
> Fixes: c004a6fe0c40 ('block/xen-blkfront: Make it running on 64KB page 
> granularity')
Hmm, a "Fixes:" tag for a change in a comment?

This might generate additional work e.g. for downstreams (we at SUSE have
scripts checking "Fixes:" tags and require such changes to be applied to
kernels having the fixed patch applied).

That said I'd prefer not having a "Fixes:" tag for such changes, but maybe
this is just due to the fact that it would be me having to apply this
patch to the SUSE kernels...


Juergen

Attachment: OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature
Description: OpenPGP digital signature