[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 13/15] swiotlb: merge swiotlb-xen initialization into swiotlb
- To: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
- From: Christoph Hellwig <hch@xxxxxx>
- Date: Tue, 15 Mar 2022 07:48:26 +0100
- Cc: Christoph Hellwig <hch@xxxxxx>, iommu@xxxxxxxxxxxxxxxxxxxxxxxxxx, x86@xxxxxxxxxx, Anshuman Khandual <anshuman.khandual@xxxxxxx>, Tom Lendacky <thomas.lendacky@xxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Joerg Roedel <joro@xxxxxxxxxx>, David Woodhouse <dwmw2@xxxxxxxxxxxxx>, Lu Baolu <baolu.lu@xxxxxxxxxxxxxxx>, Robin Murphy <robin.murphy@xxxxxxx>, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, linux-ia64@xxxxxxxxxxxxxxx, linux-mips@xxxxxxxxxxxxxxx, linuxppc-dev@xxxxxxxxxxxxxxxx, linux-riscv@xxxxxxxxxxxxxxxxxxx, linux-s390@xxxxxxxxxxxxxxx, linux-hyperv@xxxxxxxxxxxxxxx, tboot-devel@xxxxxxxxxxxxxxxxxxxxx, linux-pci@xxxxxxxxxxxxxxx
- Delivery-date: Tue, 15 Mar 2022 06:48:36 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Mon, Mar 14, 2022 at 07:07:44PM -0400, Boris Ostrovsky wrote:
>> + swiotlb_init_remap(true, x86_swiotlb_flags, xen_swiotlb_fixup);
>
>
> I think we need to have SWIOTLB_ANY set in x86_swiotlb_flags here.
Yes.
> Notice that we don't do remap() after final update to nslabs. We should.
Indeed. I've pushed the fixed patches to the git tree and attached
the patches 12, 13 and 14 in case that is easier:
Attachment:
0012-swiotlb-provide-swiotlb_init-variants-that-remap-the.patch
Description: Text Data
Attachment:
0013-swiotlb-merge-swiotlb-xen-initialization-into-swiotl.patch
Description: Text Data
Attachment:
0014-swiotlb-remove-swiotlb_init_with_tbl-and-swiotlb_ini.patch
Description: Text Data
|
