Re: [PATCH v4 11/11] xen/x86: remove cf_check attribute from hypercall handlers

["Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>]

On 3/10/22 02:34, Juergen Gross wrote:
> Now that the hypercall handlers are all being called directly instead
> through a function vector, the "cf_check" attribute can be removed.
> 
> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
> ---
> V4:
> - new patch
> ---
>  xen/arch/x86/compat.c               |  6 +++---
>  xen/arch/x86/cpu/mcheck/mce.c       |  2 +-
>  xen/arch/x86/cpu/vpmu.c             |  2 +-
>  xen/arch/x86/domain.c               |  3 +--
>  xen/arch/x86/hvm/dm.c               |  2 +-
>  xen/arch/x86/hvm/hvm.c              |  2 +-
>  xen/arch/x86/hvm/hypercall.c        |  6 +++---
>  xen/arch/x86/mm.c                   | 12 ++++++------
>  xen/arch/x86/mm/paging.c            |  2 +-
>  xen/arch/x86/physdev.c              |  2 +-
>  xen/arch/x86/platform_hypercall.c   |  2 +-
>  xen/arch/x86/pv/callback.c          | 16 ++++++++--------
>  xen/arch/x86/pv/descriptor-tables.c |  8 ++++----
>  xen/arch/x86/pv/iret.c              |  4 ++--
>  xen/arch/x86/pv/misc-hypercalls.c   | 10 +++++-----
>  xen/arch/x86/pv/shim.c              |  4 ++--
>  xen/arch/x86/x86_64/compat/mm.c     |  2 +-
>  xen/common/argo.c                   |  4 ++--
>  xen/common/compat/grant_table.c     |  2 +-
>  xen/common/compat/kernel.c          |  2 +-
>  xen/common/compat/memory.c          |  3 +--
>  xen/common/dm.c                     |  2 +-
>  xen/common/domain.c                 |  2 +-
>  xen/common/domctl.c                 |  2 +-
>  xen/common/event_channel.c          |  2 +-
>  xen/common/grant_table.c            |  3 +--
>  xen/common/hypfs.c                  |  2 +-
>  xen/common/kernel.c                 |  2 +-
>  xen/common/kexec.c                  |  4 ++--
>  xen/common/memory.c                 |  2 +-
>  xen/common/multicall.c              |  3 +--
>  xen/common/sched/compat.c           |  2 +-
>  xen/common/sched/core.c             |  4 ++--
>  xen/common/sysctl.c                 |  2 +-
>  xen/common/xenoprof.c               |  2 +-
>  xen/drivers/char/console.c          |  2 +-
>  xen/scripts/gen_hypercall.awk       |  2 +-
>  xen/xsm/xsm_core.c                  |  4 ++--
>  38 files changed, 67 insertions(+), 71 deletions(-)
>

<snip/>

> diff --git a/xen/xsm/xsm_core.c b/xen/xsm/xsm_core.c
> index 2286a502e3..eaa028109b 100644
> --- a/xen/xsm/xsm_core.c
> +++ b/xen/xsm/xsm_core.c
> @@ -219,13 +219,13 @@ bool __init has_xsm_magic(paddr_t start)
>  
>  #endif
>  
> -long cf_check do_xsm_op(XEN_GUEST_HANDLE_PARAM(void) op)
> +long do_xsm_op(XEN_GUEST_HANDLE_PARAM(void) op)
>  {
>      return xsm_do_xsm_op(op);
>  }
>  
>  #ifdef CONFIG_COMPAT
> -int cf_check compat_xsm_op(XEN_GUEST_HANDLE_PARAM(void) op)
> +int compat_xsm_op(XEN_GUEST_HANDLE_PARAM(void) op)
>  {
>      return xsm_do_compat_op(op);
>  }

Reviewed-by: Daniel P. Smith <dpsmith@xxxxxxxxxxxxxxxxxxxx>