[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 4/6] xen/cpupool: Create different cpupools at boot time
- To: Luca Fancellu <luca.fancellu@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Fri, 11 Mar 2022 08:41:06 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lKb6F2BfGn60D6OxmqevToHZVaT6xiH8n9n5hKW7J/4=; b=MLcMfFyRFRE/e0k93AO7jMRXeOZ50BA3U1QMvDOj8d/4yFNnLX2jf7qvxMBCg/YZWV50uLebrJa1PgXIKhCcDiOfcXWFWiEQ/+vrAvBg65khiAkqxrEMBglTcuXaNWD5HA2nZ2ZhOOOg95Q6m9IQI1+XSHICVxhRLG7lFzb3KK3rtmi0JW/O1qrqQdOUpv+YG/Kszi3cqXzpMiI3bQ8Iw3IsKL/0q7VRUdmbtlBAvKmWcnTXQXZrv82Eb3QKxuiVM9FkR/zEKqn6HihK+A1fg/7qU0JuYshb9aiwYazxP+GA7POdYPt2D6QN6ONFuQFllTupKz2mw6eD0VdSHfWfsg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=f1VxCOAn9Qfujs5qZE9um3njrNHuDRdNQIdUq/aGox74bFbbrnTrwFLyRPtYv4kuPhm1+kFrOls89M0rYuPVXhlyo8TdqNd7lGkinEXSVOY8+I70M/hUh4vxT8vlEZ0lX7IWO7wUX8Xxvnu9hIwhNANmW3j6Uun1uyhebv8LL8gcoXoqwY2kUSyx/T1IqpeT1UhkQYISICkHJxtUedFkWbf9N8hPMxpwYCBm5esnrvkN2xUecbmHCwseheHXAjwV/FfDd42v951HypbWcGzOGoCPlaZxiYJJJm5GwtLQRAQjqHThMODxdHhp1uKB5nGrUfJ3AZM6WBntu4DmuiSQpQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: wei.chen@xxxxxxx, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Dario Faggioli <dfaggioli@xxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Fri, 11 Mar 2022 07:41:19 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 10.03.2022 18:10, Luca Fancellu wrote:
> +chosen {
> +
> + sched: sched_a {
> + compatible = "xen,scheduler";
> + sched-name = "null";
> + };
> + cpupool_a {
> + compatible = "xen,cpupool";
> + cpupool-cpus = <&a53_1 &a53_2>;
> + };
> + cpupool_b {
> + compatible = "xen,cpupool";
> + cpupool-cpus = <&a72_1 &a72_2>;
> + cpupool-sched = <&sched>;
> + };
> +
> + [...]
> +
> +};
> \ No newline at end of file
Only seeing this in context of where I wanted to actually comment on.
Please fix.
> --- a/xen/common/Kconfig
> +++ b/xen/common/Kconfig
> @@ -22,6 +22,14 @@ config GRANT_TABLE
>
> If unsure, say Y.
>
> +config BOOT_TIME_CPUPOOLS
> + bool "Create cpupools at boot time"
> + depends on HAS_DEVICE_TREE
> + default n
Nit: Please omit this line - the default is N anyway unless specified
otherwise explicitly.
Jan
|