[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] ns16550: reject IRQ above nr_irqs
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Thu, 10 Mar 2022 17:12:51 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ubPUDdE1tqwSZQ4RBqrQwbEHk0YQGJqF57J4SOVISPc=; b=fjPxginXncGUhRGe45CwNi800mlOmmZbLJtk7pV8LRhxp0VGE/QPMLqKVcTCgXxNfZeZY3oEuBkzYBPCzjwCmyiuw6dUT1mESzf4HIJ6ObkqIA8lZExFrFSU8jtVIaGuUeYV9xt63zyiljDUzw1/lZcNh5WiP0v/Aqkdbfwv5EmkkzqGQIh2oTXZ3YbLRAY6UT8UwuH8cFFVwEobhryzk6dXq8ay2VVOzjsrBTaaVOH+tCgzcRm5jToJhirOpjywf7RCSOEPOtMtDseir1209Q7PWZPR672RwqjoUdu5uawdh++4Ub6PMJVtiDn/LH7KkqW75VHOhQaUGK83/mOt7Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DoD/6ngbl98lgbyYtsqhNyQBXs81y0OZL2Y/pySM3LXfsp4oc0wblt2RrQpXeIld8T8N8vKdtIyfWq0qP3hknxuOBcIh2oW6VTKio9d/ccq6OIWP1Siiek3uKC1FYJex0PbHVe3fvkUuUGV9WHrigUlitGwwmundPAaHmRrGKIZtILg4ZcbFf7BJkFvAqLnmO2bw1d4L5QhKpm0QfdUdXqQ3wpN4vOa+gSLPwRzXbydxyVGILdzMCZBt/w6fJVJAwt9BnEhlXSWFvIiuWeE3VYEQLXmx9ZaJrTbvAl2gPByVrT49Oyge6lV2+oGAsnTNomgJO4pt6sovjA6NbhKRDg==
- Authentication-results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 10 Mar 2022 16:13:05 +0000
- Ironport-data: A9a23:ZdkzGq4OLBqG4nh8UDy08QxRtOHHchMFZxGqfqrLsTDasY5as4F+v mEZDG/QOvbbMTPyet13aIuy9UgPuMXTz4NgSgY+/ngyHi5G8cbLO4+Ufxz6V8+wwmwvb67FA +E2MISowBUcFyeEzvuVGuG96yE6j8lkf5KkYAL+EnkZqTRMFWFw0XqPp8Zj2tQy2YPgW1vX0 T/Pi5a31GGNimYc3l08s8pvmDs31BglkGpF1rCWTakjUG72zxH5PrpGTU2CByKQrr1vNvy7X 47+IISRpQs1yfuP5uSNyd4XemVSKlLb0JPnZnB+A8BOiTAazsA+PzpS2FPxpi67hh3Q9+2dx umhurToR113IoDwnd8NVgRfECZ6F65Bw6T+dC3XXcy7lyUqclPpyvRqSko3IZcZ6qB8BmQmG f4wcW5XKErZ3qTvnez9GrIEascLdaEHOKsFvX5t13fBBOsOSpHfWaTao9Rf2V/cg+gQTayON 5pCMVKDajyRYQxvCmwQJqkhkf+QmnnnWQdqmH+s8P9fD2/7k1UqjemF3MDuUseRWcxfk0Kcp 2TH12f0GBcXMJqY0zXt2m2orv/Cm2X8Qo16PK218LtmjUOewkQXCQYKTh2rrP+hkEm8VtlDb UsO9UIGr6I/6UiqRdnVRACjrTiPuRt0c99ZCegz8gyO4qvS/QeCB2IAQyJBadopr8s/T3oh0 Vrht9H0AT1itpWFRHTb8a2bxQ5eIgBMczVEP3VdC1JYvZ+z++nfky4jUP47HvTrkvDJHArgx i2Nry86rbYUttUygvDTEU/8vxqgoZ3ATwgQ7wrRX3644g4RWLNJd7BE+nCAs68ecd/xok2p+ SFdxpPAtLxm4YSlyXTVKNjhCo1F8Bps3Nf0pVd0V6cs+D22k5JIVdABuWouTKuF3yttRNMIX KMxkV4JjHOwFCHzBUOSX25XI550pUQHPY65Ps04lvIUPvBMmPavpUmCn3K40WH3i1QLmqoiI 5qdesvEJS9EVfo3kWPtHL9DgeFDKsUCKYX7H8CTI/OPi+b2WZJoYe1dbAvmgh4RsMtoXzk5A /4AbpDXmn2zocX1YzXN8J57ELz5BSNTOHwCkOQOLrTrClM/QAkJUqaNqZt8K90Nt/kEzY/go yDiMnK0PXKi3BUr3y3RMSs9AF4uNL4ixU8G0dsEZg/5hSJ8Pd7xsM/ytfIfJNEayQCq9tYtJ 9EtcMScGPVfDDPB/jUWd57mq4J+Mh+sgGqz0+CNOlDTo7YIq9T1x+LZ
- Ironport-hdrordr: A9a23:PJ92JaNhCNHgDsBcTyP155DYdb4zR+YMi2TDiHofdfUFSKClfp 6V8cjztSWUtN4QMEtQ/uxoHJPwO080kqQFnLX5XI3SJzUO3VHHEGgM1/qB/9SNIVyaygcZ79 YdT0EcMqyAMbEZt7eC3ODQKb9Jq7PmgcOVbKXlvg9QpGlRGt9dBmxCe2Cm+yNNNW177c1TLu vi2iMLnUvpRV0nKuCAQlUVVenKoNPG0LrgfB49HhYirC2Dlymh5rLWGwWRmk52aUIE/Z4StU z+1yDp7KSqtP+2jjfaym/o9pxT3P/s0MFKCsCggtUcbh/slgGrToJ8XKDqhkF/nMifrHIR1P XcqRYpOMp+r1vXY2GOuBPonzLt1T4/gkWSvmOwsD/Gm4jUVTg6A81OicZyaR3C8Xctu9l6ze Ziw3+Zn4A/N2KOoA3No/zzEz16nEu9pnQv1cQJiWZEbIcYYLhN6aQC4UJuFosaFi6S0vFqLA BXNrCc2B9qSyLbU5iA1VMfg+BEH05DUytue3Jy9PB8iFNt7TJEJ0hx/r1qop5PzuN5d3B+3Z W2Dk1ZrsA/ciYoV9MOOA4ge7rANoWfe2OEDIqtSW6XYZ3vfUi976LK3A==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Thu, Mar 10, 2022 at 05:08:07PM +0100, Jan Beulich wrote:
> On 10.03.2022 16:47, Roger Pau Monné wrote:
> > On Thu, Mar 10, 2022 at 04:23:00PM +0100, Jan Beulich wrote:
> >> On 10.03.2022 15:34, Marek Marczykowski-Górecki wrote:
> >>> --- a/xen/drivers/char/ns16550.c
> >>> +++ b/xen/drivers/char/ns16550.c
> >>> @@ -1221,6 +1221,9 @@ pci_uart_config(struct ns16550 *uart, bool_t
> >>> skip_amt, unsigned int idx)
> >>> pci_conf_read8(PCI_SBDF(0, b, d, f),
> >>> PCI_INTERRUPT_LINE) : 0;
> >>>
> >>> + if (uart->irq >= nr_irqs)
> >>> + uart->irq = 0;
> >>
> >> Don't you mean nr_irqs_gsi here? Also (nit) please add the missing blanks
> >> immediately inside the parentheses.
> >
> > If we use nr_irqs_gsi we will need to make the check x86 only AFAICT.
>
> Down the road (when Arm wants to select HAS_PCI) - yes. Not necessarily
> right away. After all Arm wants to have an equivalent check here then,
> not merely checking against nr_irqs instead. So putting a conditional
> here right away would hide the need for putting in place an Arm-specific
> alternative.
Oh, I always forget Arm doesn't have CONFIG_HAS_PCI enabled just yet.
Roger.
|
