[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 1/2] xen/build: put image header into a separate section
- To: Roger Pau Monne <roger.pau@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 8 Mar 2022 14:57:23 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vSI9UrZBmBOAA6xi6wEm0NjZrePa1wMp1SWayJ++2zM=; b=k+gzUDLRLvnf0gPiVF8O31wGWu/C5oNDn/56U111CiexZzp/UbLypZoB+Y2cDZpVblO/lkpX2SdsvcROgdFpzmr8IToLY+144l/UgJ39p6XYMycwcnnfD9PUb6acdhtMn3QIOZjyT5mQK5ILDVkjnyDOPuh4kSEA7d4WOzkpll86EUg4zXJAYNpQDvS/kNLmRSNSpDi3SfT/jlX8lLXfKjZuIGmfP68lAXUAtwWJv6M94wkMZGlwsGlv3OaRqAfjxV3l+Q0xV1i/X2YuNdaMVMKw7d3bOlrjISvZ8yolSSXq7dDuDAVWoSpPzsCO5f77pfspiUQOpDliCsp/qRo/WQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZVGNlfoyYNfqpTH6oZ59sTbEEWueZBVTBcMqoRfKsrA29MH/WlYU+f3pkyotg23R5j+4Sb8zJuroubKpAx4j/mk/doexfTeZwF4Lf+Letl8+020TFB+jUiDMTsILEgeSP1+LboyJVospJejSa1mEsV4mCUGJZur96nc8cqgRIJFX6jMXNvl9psDmvTeWzawk7gxjLDIp7tg/mfgKaLoLTYJ0ay0ng08WSrXSJ0TOcW3gKIB5lkMsK+mcj9qZqHR4JxRhBihVx07Aoh7Hl0rSnT4c0SkiwP0955bbFdbXigQmI5th45U83N2JFvHigevXbtlTNaaXTu1PSAnZRugZJw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 08 Mar 2022 13:57:32 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 08.03.2022 14:49, Roger Pau Monne wrote:
> So it can be explicitly placed ahead of the rest of the .text content
> in the linker script (and thus the resulting image). This is a
> prerequisite for further work that will add a catch-all to the text
> section (.text.*).
>
> Note that placement of the sections inside of .text is also slightly
> adjusted to be more similar to the position found in the default GNU
> ld linker script.
>
> The special handling of the object file containing the header data as
> the first object file passed to the linker command line can also be
> removed.
>
> While there also remove the special handling of efi/ on x86. There's
> no need for the resulting object file to be passed in any special
> order to the linker.
>
> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
Looks good to me, but I have one question before feeling ready to
offer R-b:
> @@ -86,8 +84,13 @@ SECTIONS
> *(.text.kexec) /* Page aligned in the object file. */
> kexec_reloc_end = .;
>
> - *(.text.cold)
> - *(.text.unlikely)
> + *(.text.cold .text.cold.*)
> + *(.text.unlikely .text.*_unlikely .text.unlikely.*)
What generates .text.*_unlikely? And if anything really does, why
would .text.cold not have a similar equivalent?
Jan
|
