[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] build: export potentially overridden tool chain components


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
  • Date: Thu, 3 Mar 2022 15:32:00 +0000
  • Accept-language: en-GB, en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=l76gNqxQ+cyuvRF9gid7gNknHabccxBApiAem7IOqA4=; b=bvlwuUnhkvMNw3OcSdb+jkfaSrP6glw4Kfrn27A4KYPusu8qGR+AAsrzVUrUt9+mPUwhfpoTGAuvXffeaNIBohaYGD8PE7HnyJ0H7k6dTG1UGqjtkElwvYd45khWnDkksP/DvHgbs1baMCKbIHE4iWb9u4Z+qsvKnBgqzMJCkPJaSOstLy8LGKBylKlQhNRo0Wp2qEN3UTWyBFCmiLuhji6/q4S/auwbzHhr08Hha6Koz6EavhYtyke36ibSNtx6xxPN1CZGm+76rG4ZD/Wu0XZRxhyqNc0NRf9UN0CS+CR0aFYUIqnFGSJFIXfLTE9J4fEvhYtyauIBBVAv7TAMtQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Y7+qzeqN05IbQgXTQNbfDcMbcS5O5mYIKeS11Vh5sZq+N/ZWxkAjCCsyhiowqIGURDl2eDSD6VWL+0ukLJ53ZCz9i0yMTZmaNEEDkJMysFezXvCTLaLmX/K0iu9IAGOjEsEgpaPcPM0wwTrez0pblnwncpx/dpb1XdkpWDgLNUBUXDfsg1iN7QG2QuMd/UB73hRmYzd9zwR+t1TbVH3XqzIts6rbVVpmK9mqIc2XUK94sfVeSQr0pDwCxXZCW4OqPK+zlecZ5M6iG/1RyJniJQlDl45xbqVbOYG5cLAQTgUpjz8/0DouGU3P3got82QelWsi//B5jKjUAgza5qszVQ==
  • Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
  • Delivery-date: Thu, 03 Mar 2022 15:32:16 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Thread-index: AQHYLL39jNFocJHI00Sb4SF85xOtp6ytzimA
  • Thread-topic: [PATCH] build: export potentially overridden tool chain components

Hi Jan,

> On 28 Feb 2022, at 16:11, Jan Beulich <jbeulich@xxxxxxxx> wrote:
> 
> When overriding the tool chain via CROSS_COMPILE, the resulting
> components need to be made available to, in particular (but not limited
> to) the check-endbr.sh script. Note that we don't allow overriding
> ADDR2LINE yet; this would first require additions to some config/*.mk
> before it would make sense to export the resulting variable as well.
> 
> The lack of NM exporting was apparently not a problem so far, but add it
> at this occasion as well - we're using the tool, after all.
> 
> Fixes: 4d037425dccf ("x86: Build check for embedded endbr64 instructions")
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>

Cheers
Bertrand

> 
> --- a/xen/Makefile
> +++ b/xen/Makefile
> @@ -55,7 +55,7 @@ export TARGET_ARCH     := $(shell echo $
> # Allow someone to change their config file
> export KCONFIG_CONFIG ?= .config
> 
> -export CC CXX LD
> +export CC CXX LD NM OBJCOPY OBJDUMP
> 
> export TARGET := xen
> 
> 
> 




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.