[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/3] evtchn/hvm: do not allow binding PIRQs unless supported
- To: Roger Pau Monne <roger.pau@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 3 Mar 2022 13:36:45 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=T6cJPg584moZKtnWb8FtLePXUIaYX3/05kQWdyidkqs=; b=WCBzQf1OheN6B2v1htVJOvH81wXkx0iGQ+956HykfyTiVRToBsOIGZF2dH1kpxZVvskA7iriPDjJtDJuUP7mePVl+ZXKJmYxBqdO7klr5Bge/+Kqew72wky8wQfQmuRkoBnhwtNAqo3DOWJcQkS5550aLQDHBM2i6PQ3/Cs9QWrTu42z64rOwNkLIaK761iEL6Hot9t7jeR4ETvpFQP0x7UBUJtw8haTY15GpZ6wVrUDJT33Tg80hNQVOWB6Oeb42GEqLMH8bzV25qDMyonv6GcuEsqFvFaTqct5MQOaejNTP4wjPLhvPqfwUW2OGfypSuwjE1KHnQenM//rzP+Vyw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=klr5uTpWrCgnWXN7XYxXQzcMCb7s8du0G+JAUpn33UwqtzS7nh5qML/YG9a83tduPeRF/u+m7iVb3ee9quMtcwH22Y8MVaLCRtUqQAXIvY4YkXfgzMrtIq0vnHtuD0SEHWESvKa4PlwTfOlNaU/bn7mo1LEcxYCigF9RUQkobptgOIBRSxXXrEBp//ZGMqIqResnmGivd+slIyzIIrbGKakPCBoAG40mV2wUlfbOKYXS4CsHHGmsToIdmAVVC4GCGkNlshD1y7DHOopvIuoyKH1MCMAjF0ZK70uIKDw9V9tZ34uj15/8trEO0v6mtVJ1UqZB8YcwKA8jixD5qobjZg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Thu, 03 Mar 2022 12:36:52 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 03.03.2022 11:30, Roger Pau Monne wrote:
> --- a/xen/common/event_channel.c
> +++ b/xen/common/event_channel.c
> @@ -556,6 +556,9 @@ static int evtchn_bind_pirq(evtchn_bind_pirq_t *bind)
> int port = 0, rc;
> unsigned int pirq = bind->pirq;
>
> + if ( is_hvm_domain(d) && !has_pirq(d) )
Arm doesn't have has_pirq(), so some further conditional will be needed,
or has_pirq() needs adding there.
Doesn't this want further accompanying with adjustments to the checks in
physdev_{,un}map_pirq()?
> + return -ENOSYS;
-EOPNOTSUPP please.
Jan
|
