[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [PATCH] docs: correct "gnttab=" documented default
Hi Jan, On 28/02/2022 14:32, Jan Beulich wrote: On 28.02.2022 15:02, Julien Grall wrote:On 28/02/2022 10:19, Jan Beulich wrote:Defaults differ for Arm and x86, not the least because of v2 not even being security supported on Arm. Also drop a bogus sentence from gnttab_max_maptrack_frames, which was presumably mistakenly cloned from gnttab_max_frames (albeit even there what is being said is neither very precise nor very useful imo). Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx> --- a/docs/misc/xen-command-line.pandoc +++ b/docs/misc/xen-command-line.pandoc @@ -1177,7 +1177,8 @@ Specify which console gdbstub should use ### gnttab > `= List of [ max-ver:<integer>, transitive=<bool>, transfer=<bool> ]`-> Default: `gnttab=max-ver:2,transitive,transfer`+> Default (Arm): `gnttab=max-ver:1` +> Default (x86): `gnttab=max-ver:2,transitive,transfer`AFAICT, the default would not be correct on x86 when CONFIG_PV=n because transfer is not available.I can certainly split it in two x86 lines, one for PV and one for HVM. I would not have thought I need to go that far, though. I thought I would mention it because to me it feels odd to correct the default on Arm but keep the x86 one potentially inacurrate. Anyway, I am ok if you prefer to keep it like that. This is already an improvement for Arm: Acked-by: Julien Grall <jgrall@xxxxxxxxxx> Cheers, -- Julien Grall
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |