Re: [PATCH v3 02/19] xen/arm: lpae: Use the generic helpers to defined the Xen PT helpers

[Julien Grall <julien@xxxxxxx>]

On 22/02/2022 15:38, Bertrand Marquis wrote:
> Hi Julien,
Hi Bertrand,

> > On 21 Feb 2022, at 10:22, Julien Grall <julien@xxxxxxx> wrote:
> >
> > From: Julien Grall <jgrall@xxxxxxxxxx>
> >
> > Currently, Xen PT helpers are only working with 4KB page granularity
> > and open-code the generic helpers. To allow more flexibility, we can
> > re-use the generic helpers and pass Xen's page granularity
> > (PAGE_SHIFT).
> >
> > As Xen PT helpers are used in both C and assembly, we need to move
> > the generic helpers definition outside of the !__ASSEMBLY__ section.
> >
> > Take the opportunity to prefix LPAE_ENTRIES, LPAE_ENTRIES and
> > LPAE_ENTRIES_MASK with XEN_PT_.
> The list needs to be fixed to be SHIFT, ENTRIES and ENTRY_MASK.
I have fixed it in my tree and will commit it with...

> > Note the aliases for each level are still kept for the time being so we
> > can avoid a massive patch to change all the callers.
> >
> > Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>
> With this fixed:
> Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
Michal's and your's reviewed-by.

Cheers,

--
Julien Grall