[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/3] xen: Rename asprintf() to xasprintf()
- To: Roger Pau Monne <roger.pau@xxxxxxxxxx>
- From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- Date: Mon, 21 Feb 2022 11:28:39 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=n5apCjhoVMy71g7V5RBuAG/yN31n8pPIi39Bvc9yN5E=; b=gQ83Plxt4URdOF8lz2K0t1b+UuKJLhUfsTQZ75kcflIQ0syBd7SzyxNW08xlqu81biZS60YX7/3VHai1fTaW6Gj9qv4Hv7lm9iJsTUuvIF6rRmnbddd/ueOMk9xxd1wWZDBzdWKclyGmLUYfTk+gCrhHrcBqEbduTAqON+dVn4Dc+9f9JQZYe62gRJomOvqQo74+P2KYeidTa3cpXnzczQWlBsjb0ZbUhoeA+Uukmssj/26kIFKKaiZccH3gUQ+9LOKd0BDqd7vT1b0ulPfyTjc4ACMhYZx0lICY3mdf7Rc35I5ooY9ut08IhBETdQH1YGuthvdhc78CsJuXByToWA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WP/6U2nnyCnIiEfY0d60OP60WJgdSYpV2DEyiSyKk4XaBYD3kIdx7G5RHlz8yzFvbCHuiNlFtg9skVQbDyGIukVLjkXq3zDdoXCucKHOQmz5eCjgM4He9edQChIhuEiTHO1ZJWoHponD21cG+pyS5y3rMKq36LUe7cOu2qlRSagmbofU7c6bpWBx0xUC2ByKAeZLzyRDEFP3nnpHdRhXaBFg3584enJxD/QpzWFXHgGsV2iDpfMctM5IcQArtSJQ4lH/ZfcRdC6NOYMLsTZClIOworqO9R/UqRV2xookCIqgiHbJWOX8xertfvvfl79DL9vq55R5bzLkjVIDL/BJbw==
- Authentication-results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Julien Grall <julien@xxxxxxx>, Paul Durrant <paul@xxxxxxx>
- Delivery-date: Mon, 21 Feb 2022 11:29:02 +0000
- Ironport-data: A9a23:hIPcV60FkxEPFO3GqfbD5QNxkn2cJEfYwER7XKvMYLTBsI5bpz0Ax zFKCzyAOq3bMDfyfoxzO4ripE1Q7cDQm9QwGQFspC1hF35El5HIVI+TRqvS04J+DSFhoGZPt Zh2hgzodZhsJpPkjk7xdOCn9xGQ7InQLlbGILes1htZGEk0GE/NtTo5w7Rj2tQy2IDga++wk YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx /1Llqy9cCUEY5fyo+AYUh5AOGJfAoNvreqvzXiX6aR/zmXDenrohf5vEFs3LcsT/eMf7WNmr KJCbmpXN1ba2rzwkOnTpupE36zPKOHCOo8Ft24m5jbeFfs8GrjIQrnQ5M8e1zA17ixLNaiAN 5pENGc0BPjGSw9sNnRIS8xhpsKTql6hKxtlq2ynu7VitgA/yyQuieOwYbI5YOeiWsF9jkue4 GXc8AzRAAweNdGZ4SqI9DSrnOCntTvyRYY6BLC+sPlwjzW73XcPARcbUV+6p/iRiUOkXd9bb UsO9UIGvaU0sUCmUNT5dxm5u2Kf+A4RXcJKFO834x3LzbDbiy6YGWosXjNHcMYhtsI9WXotz FDht/HDCCFrsbaVYWmA7brSpjS3URX5NkdbO3VCF1FcpYC+/sdj1XojU+qPDoazre34IBPdn gq0lyw7hrILpo0q6IuSqAWvby2XmrDFSQs85wPyV22j7x9kaIPNW7FE+WQ3/t4bct/HEwDpU Gws3pHHsbtQVc3leDmlHb1VdIxF8cppJ9E1bbRHO5A6vwqg9He4FWy7yGEvfRw5WirolNKAX aMyhe+zzMIJVJdJRfUuC25UNyjN5fK9fekJrtiOMrJzjmFZLWdrBh1Ga0+KxHzKm0Mxi6w5M przWZ/yUStBWfg2kWvrHbZ1PVoXKscWnz67eHwG507/jer2iIC9Et/pz2dinshmtfjZ8W05A v5UNteQygU3bQENSnK/zGLnFnhTdSJTLcmv86R/L7ffSiI7SDBJI6KAmtsJJt0695m5Y8+Vp xlRrGcDkwGh7ZAGQC3XAk1ehETHB8gn9itjZXR2VbtqslB6CbuSAG4kX8JfVZEs9fB5zO4yS P8Aes6aBe9IRCiB8DMYBaQRZqQ/HPh3rWpi5xaYXQU=
- Ironport-hdrordr: A9a23:ScxaAaEfCic+8bEepLqFRpHXdLJyesId70hD6qkvc3Nom52j+/ xGws536fatskdtZJkh8erwXZVp2RvnhNFICPoqTMuftW7dySWVxeBZnMffKljbdREWmdQtrJ uIH5IOa+EYSGIK9/oSgzPIUurIouP3iJxA7N22pxwGLGFXguNbnnxE426gYxZLrWJ9dP4E/e +nl6x6Tk2bCBMqh6qAdxs4dtmGg+eOuIPtYBYACRJiwhKJlymU5LnzFAXd9gsCUhtUqI1SsV Ttokjc3OGOovu7whjT2yv49JJNgubszdNFGYilltUVEDPxkQylDb4RGIFq/QpF4t1H2mxa1O UkkC1QePibLEmhOF1dlCGdnjUIFgxeskMKh2Xo2UcL6vaJOw7SQ/Ax+76xNCGpsXbI9esMoJ 6ilQiixutqJAKFkyLn69fSURZ20kKyvHo5iOYWy2dSSI0EddZq3MciFW5uYd499RjBmcga+S hVfbXhzecTdUnfY2HSv2FpztDpVnMvHg2eSkxHvsCOyTBZkH1w0kNdnaUk7zo93YN4T4MB6/ XPM6xumr0LRsgKbbhlDONERcesEGTCTR/FLWrXK1X6E6MMPW7LtvfMkf8IzfDvfIZNwIo5mZ zHXl8dvWkue1j2AcnLx5FP+gClehTKYd0s8LAo23FUgMyPeFOwC1zxdLkHqbrUn8ki
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHYJwpOs0szyq0MVUKA4rk1u5+GKayd3CkAgAACGQA=
- Thread-topic: [PATCH 2/3] xen: Rename asprintf() to xasprintf()
On 21/02/2022 11:21, Roger Pau Monné wrote:
> On Mon, Feb 21, 2022 at 10:02:53AM +0000, Andrew Cooper wrote:
>> Coverity reports that there is a memory leak in
>> ioreq_server_alloc_rangesets(). This would be true if Xen's implementation
>> of
>> asprintf() had glibc's return semantics, but it doesn't.
>>
>> Rename to xasprintf() to reduce confusion for Coverity and other developers.
> It would seem more natural to me to rename to asprintk.
Why? This infrastructure doesn't emit the string to any console.
> I assume
> there's no way for Coverity to prevent overrides with builtin models?
>
> I've been searching, but there doesn't seem to be any option to
> prevent overrides by builtin models?
No, and we absolutely wouldn't want to skip the model even if we could,
because that would break asprintf() analysis for userspace.
~Andrew
|
