[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH RESEND v2] x86: introduce ioremap_wc()
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Fri, 18 Feb 2022 10:09:22 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0ett+XDu2hDr6Veiai8PvSlhBtqqKmzxcxfDfOHu3C8=; b=XJbDtseifBFHoAIh7JMdI+dgT5U1mvmmQI26/e/Udi+h+LHRwkHmxoi5ZwIqlfn/i3yueOe6jGAVtONJQZV0YTPSjL1hZaSRJPG0yWOUO9Xsc5zSclJXGs6IrBGJhhKEEqG6R8Y8LLlDwICvBqxuOPP2cRPCmUyW0fdvVgFaLaIbIjCsNH0u9VjgsCGMNjZsGtM+Th4+m38cDay2wYu76t/VBnaU3ZrjmELQxOdIi6XdU6RQmqBF5j9JQwBpV3Y/J+fbA6AZmWwlVGJWjZQzoOd8Vdw8A29Pdp97Oq5qKsjKwd15WgNT6YfTnVt53gW4Fxo6tRivHuyncXTg7K4POw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YgkvOQ1C2ckD1h23ZEccbW2i6AJm0TgFKYrk7ioBpIqbGDTojLk81qWITBu0et+eIH9Ldib0nslooJzZuRtYpzmkFX8Zk23UAjrF6ioeUr9CsX21AdNLtz+oGY5gPCdtC/K/NJJe67rJhzFmGZ1fkNBqw/5fKQDx9261fW6PGpZTuSTvpZT1EH0YfKVFbukgtzFsfyWzm+CzRR+1ZM+AAi2e7Iw5W9MIxGoZuAPkJ8C8eUs9wiR9y+i6RiG6RBkKTjN1lQS0eJhQOO1VGRSgDj5wr02ifTDWbpy2OiTLEYiBntHWCN/g0ByJkcEx+nCMYfT98DeQBCvCQeR1YvwwNQ==
- Authentication-results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Fri, 18 Feb 2022 09:09:57 +0000
- Ironport-data: A9a23:MhIrnKliLzNJXsynzHodhgXo5gyWJkRdPkR7XQ2eYbSJt1+Wr1Gzt xIdC2mGPP7ZajehfdpyaoWw9xtVvsLVmoNhT1RqrCk1EiMWpZLJC+rCIxarNUt+DCFioGGLT Sk6QoOdRCzhZiaE/n9BCpC48T8kk/vgqoPUUIYoAAgoLeNfYHpn2UILd9IR2NYy24DjWlPV4 LsenuWEULOb828sWo4rw/rrRCNH5JwebxtB4zTSzdgS1LPvvyF94KA3fMldHFOhKmVgJcaoR v6r8V2M1jixEyHBqD+Suu2TnkUiGtY+NOUV45Zcc/DKbhNq/kTe3kunXRa1hIg+ZzihxrhMJ NtxWZOYb18CY4fNvu8hDDJmEBt1P6NEwa74GC3q2SCT5xWun3rExvxvCAc9PJEC+/YxCmZLn RAaAGlTNFbZ3bvwme/lDLk37iggBJCD0Ic3oHZvwCufFf87aZvCX7/L9ZlT2zJYasVmQ6qDP 5NFNGIHgBLoODhwJHIUA6oHg+aPujquXCNRrwqUjP9ii4TU5FMoi+W8WDbPQfSVQe1Fk0Deo XjJl0zpDxdfONGBxD6t9nO3mvSJjS79QJgVFrCz6rhtmlL77m4ZBQASVFC7ieKkkUP4UNVaQ 3H44QJ38/J0rhbyCICgAVvo+xZooyLwRfJ2S8ZnwgCrwZaLyDiaPGMGQDx4eeMf4ZpeqSMR6 neFmNbgBDpKubKTSG6A+rr8kQ5eKRT5PkdZO3ZaEFJtD83L5dhq00mRFooL/Lud04WtcQwc1 Qxmu8TXa187qccQn5u28lnc695HjsiYF1Vljuk7s4/M0++YWGJHT9D5gbQ4xawZRGp8crVnl CFV8yR5xLpTZaxhbATXHI0w8EiBvp5pygH0j191BIUG/D+w4XOldo04yGggeBowaJpcKGO3O RW7VeZtCHl7ZSrCgUhfOd/ZNijX5fK4SYSNug78NbKinaSdhCfYpXozNCZ8LkjmkVQ2kLFXB HtoWZ3EMJruMow+lGDeb75EidcDn3lirUuOFcGT50n2itK2OS/KIYrpxXPTN4jVGovf+16Lm zueXuPXoyhivBrWOHePqtdLdQhQRZX5bLivw/Fqmie4ClMOMEkqCuPLwKNnfIpgnq9PkfzP8 G37UUhdoGcTT1WeQelWQhiPsI/SYKs=
- Ironport-hdrordr: A9a23:biqm1azzXrkYgj28/9BSKrPwKL1zdoMgy1knxilNoHtuA6ulfq GV7ZAmPHrP4wr5N0tNpTntAsa9qBDnlaKdg7N+AV7KZmCP0gaVxepZjLfK8nnNHDD/6/4Y9Y oISdkaNDQoNykYsS8t2njbL+od
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Thu, Feb 17, 2022 at 04:57:41PM +0100, Jan Beulich wrote:
> On 17.02.2022 16:50, Roger Pau Monné wrote:
> > On Thu, Feb 17, 2022 at 04:02:39PM +0100, Jan Beulich wrote:
> >> On 17.02.2022 15:47, Roger Pau Monné wrote:
> >>> On Thu, Feb 17, 2022 at 12:01:08PM +0100, Jan Beulich wrote:
> >>>> --- a/xen/drivers/video/vga.c
> >>>> +++ b/xen/drivers/video/vga.c
> >>>> @@ -79,7 +79,7 @@ void __init video_init(void)
> >>>> {
> >>>> case XEN_VGATYPE_TEXT_MODE_3:
> >>>> if ( page_is_ram_type(paddr_to_pfn(0xB8000),
> >>>> RAM_TYPE_CONVENTIONAL) ||
> >>>> - ((video = ioremap(0xB8000, 0x8000)) == NULL) )
> >>>> + ((video = ioremap_wc(0xB8000, 0x8000)) == NULL) )
> >>>> return;
> >>>> outw(0x200a, 0x3d4); /* disable cursor */
> >>>> columns = vga_console_info.u.text_mode_3.columns;
> >>>> @@ -164,7 +164,11 @@ void __init video_endboot(void)
> >>>> {
> >>>> case XEN_VGATYPE_TEXT_MODE_3:
> >>>> if ( !vgacon_keep )
> >>>> + {
> >>>> memset(video, 0, columns * lines * 2);
> >>>> + iounmap(video);
> >>>> + video = ZERO_BLOCK_PTR;
> >>>> + }
> >>>> break;
> >>>> case XEN_VGATYPE_VESA_LFB:
> >>>> case XEN_VGATYPE_EFI_LFB:
> >>>
> >>> I think in vesa_endboot you also need to iounmap the framebuffer
> >>> iomem?
> >>
> >> Again part of the full series. I guess I was a little inconsistent
> >> with leaving the VGA unmap in here, but breaking out the VESA part.
> >> It's been a long time, but I guess I did so because the VESA part
> >> needs to touch two files.
> >
> > I think you are hesitant to include the chunks for the above items? (or
> > maybe I'm not properly accounting for their complexity).
>
> There's no complexity, it's really just that the zapping of the pointer
> needs to be done in a different place from where the unmap is. See below.
>
> Jan
>
> video/vesa: unmap frame buffer when relinquishing console
>
> There's no point in keeping the VA space occupied when no further output
> will occur.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
For both patches, the one inline here and "x86: introduce
ioremap_wc()".
While at it, I think you should also push "video/vesa: drop
"vesa-mtrr" command line option".
Thanks, Roger.
|
