[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 4/5] xen/cpupool: Create different cpupools at boot time
- To: Dario Faggioli <dfaggioli@xxxxxxxx>
- From: Luca Fancellu <luca.fancellu@xxxxxxx>
- Date: Wed, 16 Feb 2022 16:45:16 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8SDQQpjilmnDI3MclnSGYcerVK7NcRvz1xk60aNxIMY=; b=FjX1mItQZv4b7YB9DB/+0CbzjddTG4c5pbmLJWwCFaHHdx7s7rEIw9oZP9uq3Xq67Pc9csDTxTtKUzPOxtdnN7n9fOp9ZPEcuPK/nD2G18NorwFWZqUsZneKg97DlULKMti6CNGlKhdM2+frV0cp1G5oW/L509OUOTX7PCqTF12ZsUMql+uGaBlxNdfkalI3xnSTrT/6r6rwBzma+xQypzkCi7jX0Fg0v4617IBZ9WvwKXDz4MLpD3vraDLiZcfV99U6qoXR2HsAJnEMwEgBz/w8b6SVXi8Hvk8BZznaOQfPDjtz73DMxmt6Oofe+zZ9HpYcvs9KXbRZy/9uECu+qA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mqLGfNg6d9rMdjF5yR/0+i4DfieAEslF9tFtt/L9Wepc5yWga7WhGpTa92r3LNN+ODq8E/QaJ4imQNleqLokbLZ1uvrYTA7EDCfkN7VK0IHOuG8e2ZY+3NgwsRiVpoiYOOd48OPshwUPHl915UGnQxWLv0kQ2a5PX8Dg9Mp/+/zUHdtic76OtVGMxE7JEW0BWx35baIQRXNk0y5OyxnsoNsfT5W93OE02jZt8MJmbxenxAj3v6lZeOqq2KWLUpmK6Sjyb5q1R9Lgfzc38lZG6sEPieadpAi+pB+xTjk5x5R/wsd2vGB+WwkPLFRF9R8Mw1ak1kHDppANhGUGXMzKIA==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Juergen Gross <jgross@xxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Chen <wei.chen@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Wed, 16 Feb 2022 16:46:02 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
> On 16 Feb 2022, at 16:32, Dario Faggioli <dfaggioli@xxxxxxxx> wrote:
>
> On Wed, 2022-02-16 at 12:37 +0000, Luca Fancellu wrote:
>>> On 16 Feb 2022, at 06:18, Juergen Gross <jgross@xxxxxxxx> wrote:
>>> On 15.02.22 18:56, Luca Fancellu wrote:
>>>>>
>>>> Yes, however I think the parser to handle everything by command
>>>> line would
>>>> be huge due to input sanitisation and not easy enough as the DT,
>>>> however
>>>> I see Hyperlaunch has plans to use DT on x86 so I guess it would
>>>> be ok to make
>>>> this feature common once the DT is available also on x86.
>>>
>>> Everything not being explicitly specific to Arm should be in common
>>> code. Think of the work in progress for Risc-V.
>>
>> Ok I will put it in common and I will make the feature depend on
>> HAS_DEVICE_TREE.
>>
> Can't we split the DT parsing logic & code, which is fine to be either
> ARM or HAS_DEVICE_TREE specific, and the actual core logic, which can
> be common and not gated by any particular condition?
>
> This way, if one wants to add boot-time cpupool to x86 via command
> line, he/she would have to implement "only" the command line parsing.
>
> I've looked at the code, and I appreciate that it's not trivial and
> that it's probably impossible to achieve 100% decoupling (at least not
> without adding a lot more complexity)... But any step we can make in
> that direction would be, IMO, a good investment.
>
Hi Dario,
Sure I will try to do my best to point in that direction.
Cheers,
Luca
> Regards
> --
> Dario Faggioli, Ph.D
> http://about.me/dario.faggioli
> Virtualization Software Engineer
> SUSE Labs, SUSE https://www.suse.com/
> -------------------------------------------------------------------
> <<This happens because _I_ choose it to happen!>> (Raistlin Majere)
|
