[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/3] x86/retpoline: rename retpoline Kconfig check to include GCC prefix
- To: Roger Pau Monne <roger.pau@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 16 Feb 2022 10:45:45 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oAiZpV8gHbcsIUNxUGTOnA8YjcbALk4FxFPOjUWWkp0=; b=au5voNi0ujQPdfta/eoLsDQ3Ao6hnEDytpyD6pvU+BsjMAjenv/5k7gGBjfSLTaPdMQv23X/xZJ6g+xZkPvMa/v8RwcPIanz6wcJWVOBUIk7wooUhDR7i3LI0hZ75yGTd2olLrYJRftgi2YtfuuTNlDZBgZEAOciE856lXbGSlA49hCGkBbXP91XjmR2dh4/Kly54+1dwYeXcADdC1PsSp76mqldaoXzyxMfoTj1tVFcugYTzhPkFRYb4t9Ub4cDjTC4ebhCKhk2pnfZ082d0WhVtqYNjp1xP6E25GuBoL53evWZtv/uZII3T+gnS4X6WSCAeHUCQzNL+tlR7sGcoA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iln5nIa5IjawOsXcfGkITsZrUv3DvhpqrURR9iUHdYMBtUNPdFYJk8qWCNWP/0tf1wJkiEFdgC8JQ9ctjctvLDMp2I+FZwMK45yffbDzbylRtU7gE/Lg5XlgV6wMvXxLhF0Ewi47cHqP8QfP5FlAoTnbKfZhk9hlyeoBo44ZlXUHdhjkKzgC2ZsGIMLkAzaSrDqWtUrWSErRviiApeES0gnTMZw13Z7VZ9Z5Jwx8ylvWuCq7IRGUGJErUQKgGwdKzjAFER8pddjqTCCXJf53144EPCQfa4ZzskNt2/C1dvkZzA5XJK/ESMZV1nyr7jM8qMw+KBwskCweZ2isM1ZnVg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Wed, 16 Feb 2022 09:46:16 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 16.02.2022 10:02, Roger Pau Monne wrote:
> Current retpoline checks apply to GCC only, so make it obvious by
> prefixing the Kconfig option with GCC. Keep the previous option as a
> way to signal generic retpoline support regardless of the underlying
> compiler.
>
> No functional change intended.
>
> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
with one remark:
> --- a/xen/arch/x86/Kconfig
> +++ b/xen/arch/x86/Kconfig
> @@ -32,9 +32,13 @@ config ARCH_DEFCONFIG
> string
> default "arch/x86/configs/x86_64_defconfig"
>
> -config INDIRECT_THUNK
> +config GCC_INDIRECT_THUNK
> def_bool $(cc-option,-mindirect-branch-register)
>
> +config INDIRECT_THUNK
> + depends on GCC_INDIRECT_THUNK
> + def_bool y
I think it is more logical (and more consistent) if "depends on"
would come after the basic type (i.e. the "def_bool" here).
Jan
|
