[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 34/70] x86/emul: CFI hardening
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 14 Feb 2022 14:38:01 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Z3f2t+XhwEtN4J8hpx0P3ybYg15Md7WRWj+4V2dsWfU=; b=Tj/RlJuXMxTELeC5Sa6YBDMEDTgq18M2cXZVx5TkQfz0KiI7SepEhqZ6ASfMkzDXSpwTXIeMTg4Vs4CzLYRHQft/wVIblE0T6U9Unxb/67GmuYpMihkiNhsCi428fxAOaT5C1Q/Eeuwqs+Rak08cM4iE1UZd4gY+bN+MQ1EoXsNtwRVbuYDXVcCp9gqu1WqNdLTVGyrzpnHxy8A10UeOJXTB598Ii/p6RCWn2ThPraHZgupaVIYX7/roTeq+8CmESBBZU/aGcMVlgWwLQMiGOP0lzJpOveYANCZX4bWw8I2fqUyXyeFVrgIqa7WzXDYVwBsydpS/nfH/Z9o4QX0V+A==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=egDAskVMfwBh1VfTdNfd/ISMgSxp4oJbxOkyqlmNHchTipJMEZ5scmsU7/8wNq5xtw7C7c7iCm2YSstCFLLiuO7mucrFIvEJZE8T7lvqyp3Bn0ZnSmSTD6Y4F/nPEBuB/+caEIA6DcXx1/wOA09DS0iA/qUTdk6xwC7ziiMP+Ks2fjAR8npH3QCudkJF4M6yOQNz/cZyN3zZxdhckUE5YFWHm5Le2ADor2IXQO07Uo487s4JK70B068sCk/QoGrdRvRZGyVGUb+ITSJz3qhKveHIadjoBqNl1xT2y6ajDvLOFfS1T2v9MJ1jEvuLZQ6KWOAs+FqCgPN2/PMHI+JKcQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 14 Feb 2022 13:38:22 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 14.02.2022 13:50, Andrew Cooper wrote:
> Control Flow Integrity schemes use toolchain and optionally hardware support
> to help protect against call/jump/return oriented programming attacks.
>
> Use cf_check to annotate function pointer targets for the toolchain.
>
> pv_emul_is_mem_write() is only used in a single file. Having it as a static
> inline is pointless because it can't be inlined to begin with.
I'd like you to consider to re-word this: It being static inline was for
the case of there appearing a 2nd user. I don't view such as pointless.
Jan
|
