[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC v2 2/8] libs: libxenhypfs - handle blob properties
- To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@xxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 9 Feb 2022 15:01:09 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=a5amoCfjhU59nhUznhyRPozLp59hxbfkFQLxJuIYR8Q=; b=XykOymlZ9sYw7DNxM7a0uN3wjuA8dMb7hDfFcRpEuTun6dxCDljFJEVlx82KDzd0wLLM4pz95cqxCFRdF3LKUM0ZL7eUNy299A/1c1FkMxu51cdBEA+bBxQTWGKobd0j9RaCKe/FgJMGMqxCDMrYDtJtg4P6LRwLPijI+RoeFtuq9gK2Sdjw8tH08onoO7jPUbW5AwbPtACozToExVGsbKAcFkgIafkgg1srofGU45G7KChhDkxeGqsR+PdavGznu5jHDy+LWU67Re4wQrzL1UrspScLoESLFHaozDZjX/KeeTo+Fh0nBIMC6T871W8T/cKGKs7Lr5zUhxkM+lFgVA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SCFSVGMnSqScD08/HkdoSI1QYEScnliFD05fGJCkX20NGvH2Es/Qva4YEKeFmAwmllt1Ew8p9twNytI3s3b3YyaruwBCqRsMj9Lv84YxoyqtR7rmLZQ4EJyFMS78jgZ1ydPY13cIHu6iyj7h1P5BgK4rMh6sMp6nxSyhd5zXA1aZeWMQtapiqN2KT35LF7rXcupYQlt42S5QVE5jLqjALMpdRxD/+AwIER1S514kdiqV8k1XTL/GEkcQGncj6ou++CGPepPFINhbPkriUn6EYHSJZMyJWof3fMs3z5uLc5e9UBJ0N9e5xpttyAAdwHqCFfElxMr6Iy+HqKob2ThAGw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Juergen Gross <jgross@xxxxxxxx>, Wei Liu <wl@xxxxxxx>, Oleksii Moisieiev <Oleksii_Moisieiev@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 09 Feb 2022 14:01:18 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 09.02.2022 14:47, Oleksandr Andrushchenko wrote:
> Hi, Oleksii!
>
> On 08.02.22 20:00, Oleksii Moisieiev wrote:
>> libxenhypfs will return blob properties as is. This output can be used
>> to retrieve information from the hypfs. Caller is responsible for
>> parsing property value.
>>
>> Signed-off-by: Oleksii Moisieiev <oleksii_moisieiev@xxxxxxxx>
>> ---
>> tools/libs/hypfs/core.c | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/tools/libs/hypfs/core.c b/tools/libs/hypfs/core.c
>> index 52b30db8d7..d09bba7d8c 100644
>> --- a/tools/libs/hypfs/core.c
>> +++ b/tools/libs/hypfs/core.c
>> @@ -307,8 +307,6 @@ char *xenhypfs_read(xenhypfs_handle *fshdl, const char
>> *path)
>> errno = EISDIR;
>> break;
>> case xenhypfs_type_blob:
>> - errno = EDOM;
>> - break;
> This will need a /* fallthrough */ I guess
Why? There's no statement left before the next case label.
Jan
>> case xenhypfs_type_string:
>> ret_buf = buf;
>> buf = NULL;
|
