[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH V5] xen/gnttab: Store frame GFN in struct page_info on Arm
- To: Julien Grall <julien@xxxxxxx>
- From: Oleksandr Tyshchenko <Oleksandr_Tyshchenko@xxxxxxxx>
- Date: Mon, 7 Feb 2022 17:58:14 +0000
- Accept-language: en-US, ru-RU
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hsIXGB17eFaEWtUTc9hevLg1d7sVITjjbZekA2/V+0M=; b=SmOgxKyoEd5QhcLH2jpzjfK8bGUK9HIJMyCGn7TovIkJQZeV69FlBVpLopeRfylnjw6P+Uo8jNDURLwqQtzl+J2vntgkkzwoez8MYFaW255D2iS9RnLzTL2Rw7FmyuRVJxDBSOGRCwOGSN3ZdV4QGkOm9gk+9TW7is46bCIqZRFT2Khw0sfYpRSbh2WO6ocxpRHA0RoC4E6JcknVwog1oECWqh/7hxzReM1znXxX02JAlvPbHmYdfcTWXECPltq1CvoG7ffirHSB+tUVqYL0zy2YBC8dY/pv0/hWMvOxpAWhG2T9W8INo7gUQw67B+XXGUNE74plh183sAJLQ1zZqw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lJKqqxzz4z0DjZw9DPkUz02F+8wu3M/lwESewqEty9NA4GlQuIyrnIwKDPxCS5mDj7/9MpTplStiDfIK34+RAdIiZDY0QA4fQna9JfvdCfddKiqZMWtUUDJRLItkllaTMaRECvA7UF67dJtkHptl3DEwrkE7fl9LdwjWE9RhhcDCyZIfPxXQ9mdnl1WdS6Do3YBaYW5SlGnpmxI5uy4zsjTT/iZN7lZ51/jSac4KQJvSZMkfKhaLyE5mm9mQX+7qcpZD5XZoGf3uHTuOTLjZqu/wPFfq3I48V8+ozx+5pGAG5FXu6Z+ygQU6iVxtNz7hnras+d0DRLInjIghk+4Qvg==
- Cc: Oleksandr <olekstysh@xxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Bob Eshleman <bobbyeshleman@xxxxxxxxx>, Alistair Francis <alistair.francis@xxxxxxx>, Connor Davis <connojdavis@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 08 Feb 2022 05:06:37 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHYAomKM/4d8JNsdEqc8nNA4dib2KxWDBOAgAAkKACAMl6jAIAABJuA
- Thread-topic: [PATCH V5] xen/gnttab: Store frame GFN in struct page_info on Arm
On 07.02.22 19:41, Julien Grall wrote:
> Hi,
Hi Julien
>
> Sorry for the late reply.
np
>
> On 06/01/2022 16:30, Oleksandr wrote:
>
> So I agree with Jan that the name should be adjusted if it stays where
> it is.
>
> That said, I would actually prefer the adjustment in
> alloc_heap_pages(). It is one less assignment per page and I don't
> expect any issue with setting the bits to INVALID_GFN everywhere in
> the future on Arm.
Sorry I lost the context. To clarify, are you speaking about what I
proposed at [1]?
If yes, then ...
>
> Note that you would also need to update acquire_staticmem_pages().
... yes, will do.
[1]
https://lore.kernel.org/xen-devel/b4832284-9bfc-d600-14b1-1784f53e5d9f@xxxxxxxxx/
>
>
> Cheers,
>
--
Regards,
Oleksandr Tyshchenko
|
